Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 2046603002: Prefix png functions (Closed)

Created:
4 years, 6 months ago by scroggo_chromium
Modified:
4 years, 6 months ago
Reviewers:
msarett, scroggo, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@pngconf
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Prefix png functions This way multiple copies of libpng can coexist. Update libpng's README.google GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2046603002 Committed: https://skia.googlesource.com/skia/+/09f5cd44ae30f7089cde0131a3d07abf4c47af67

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+466 lines, -2 lines) Patch
M third_party/libpng/README.google View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/libpng/pnglibconf.h View 1 chunk +6 lines, -0 lines 1 comment Download
A third_party/libpng/pngprefix.h View 1 chunk +455 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (5 generated)
scroggo_chromium
4 years, 6 months ago (2016-06-06 15:19:58 UTC) #2
scroggo_chromium
4 years, 6 months ago (2016-06-06 15:20:12 UTC) #4
msarett
LGTM
4 years, 6 months ago (2016-06-06 15:22:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046603002/1
4 years, 6 months ago (2016-06-06 15:28:05 UTC) #7
mtklein
https://codereview.chromium.org/2046603002/diff/1/third_party/libpng/pnglibconf.h File third_party/libpng/pnglibconf.h (right): https://codereview.chromium.org/2046603002/diff/1/third_party/libpng/pnglibconf.h#newcode217 third_party/libpng/pnglibconf.h:217: #define PNG_PREFIX #define PNG_PREFIX skia_ ?
4 years, 6 months ago (2016-06-06 15:29:59 UTC) #9
mtklein_C
On 2016/06/06 at 15:29:59, mtklein wrote: > https://codereview.chromium.org/2046603002/diff/1/third_party/libpng/pnglibconf.h > File third_party/libpng/pnglibconf.h (right): > > https://codereview.chromium.org/2046603002/diff/1/third_party/libpng/pnglibconf.h#newcode217 ...
4 years, 6 months ago (2016-06-06 15:39:39 UTC) #10
mtklein_C
On 2016/06/06 at 15:29:59, mtklein wrote: > https://codereview.chromium.org/2046603002/diff/1/third_party/libpng/pnglibconf.h > File third_party/libpng/pnglibconf.h (right): > > https://codereview.chromium.org/2046603002/diff/1/third_party/libpng/pnglibconf.h#newcode217 ...
4 years, 6 months ago (2016-06-06 15:39:40 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 15:57:53 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/09f5cd44ae30f7089cde0131a3d07abf4c47af67

Powered by Google App Engine
This is Rietveld 408576698