Revert of In official builds, let CHECK(false) crash instead of calling BreakDebugger.

Revert of In official builds, let CHECK(false) crash instead of calling BreakDebugger. (patchset #2 id:20001 of https://codereview.chromium.org/1982123002/ )

Reason for revert:
Unfortunately crrev.com/1982123002 causes loss of
crash reports on Android arm64 (and supposedly also CrOS).
This is because __builtin_trap() raises a SIGILL on x86 and
arm but SIGTRAP on arm64. Breakpad does not handle SIGTRAP (yet).
Temporarily reverting this CL until SIGTRAP support for breakpad lands.

BUG=599867, 614865
Original issue's description:
> In official builds, let CHECK(false) crash instead of calling BreakDebugger.
>
> This should save some binary size and make things a bit faster, without ill
> effects.
>
> See bug comment 15, and brettw's and my comments on
> "[blink-dev] Update of wtf/Assertions.h, and ASSERT macros deprecation"
>
> BUG=599867
>
> Committed: https://crrev.com/481a8ec8b24df24795c63fd4ec26f3670d516db8
> Cr-Commit-Position: refs/heads/master@{#394035}

TBR=danakj@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=599867
Committed: https://crrev.com/6ff194f572f62ff4989aaadc9af6616eb78b954a
Cr-Commit-Position: refs/heads/master@{#398084}

[Primiano Tucci (use gerrit), 2016-06-06 14:58:09]

Created Revert of In official builds, let CHECK(false) crash instead of calling
BreakDebugger.

[Primiano Tucci (use gerrit), 2016-06-06 16:17:15]

The CQ bit was checked by primiano@chromium.org

[Primiano Tucci (use gerrit), 2016-06-06 16:17:28]

The CQ bit was unchecked by primiano@chromium.org

[Primiano Tucci (use gerrit), 2016-06-06 16:17:34]

The CQ bit was checked by primiano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-06 16:17:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2046593002/1

[Nico, 2016-06-06 18:03:31]

lgtm

[commit-bot: I haz the power, 2016-06-06 18:18:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-06 18:18:26]

Dry run: This issue passed the CQ dry run.

[Primiano Tucci (use gerrit), 2016-06-06 19:06:48]

The CQ bit was checked by primiano@chromium.org

[commit-bot: I haz the power, 2016-06-06 19:07:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2046593002/1

[commit-bot: I haz the power, 2016-06-06 19:14:00]

Description was changed from

==========
Revert of In official builds, let CHECK(false) crash instead of calling
BreakDebugger. (patchset #2 id:20001 of
https://codereview.chromium.org/1982123002/ )

Reason for revert:
Unfortunately crrev.com/1982123002 causes loss of
crash reports on Android arm64 (and supposedly also CrOS).
This is because __builtin_trap() raises a SIGILL on x86 and
arm but SIGTRAP on arm64. Breakpad does not handle SIGTRAP (yet).
Temporarily reverting this CL until SIGTRAP support for breakpad lands.


BUG=599867,614865

Original issue's description:
> In official builds, let CHECK(false) crash instead of calling BreakDebugger.
> 
> This should save some binary size and make things a bit faster, without ill
> effects.
> 
> See bug comment 15, and brettw's and my comments on
> "[blink-dev] Update of wtf/Assertions.h, and ASSERT macros deprecation"
> 
> BUG=599867
> 
> Committed: https://crrev.com/481a8ec8b24df24795c63fd4ec26f3670d516db8
> Cr-Commit-Position: refs/heads/master@{#394035}

TBR=danakj@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=599867
==========

to

==========
Revert of In official builds, let CHECK(false) crash instead of calling
BreakDebugger. (patchset #2 id:20001 of
https://codereview.chromium.org/1982123002/ )

Reason for revert:
Unfortunately crrev.com/1982123002 causes loss of
crash reports on Android arm64 (and supposedly also CrOS).
This is because __builtin_trap() raises a SIGILL on x86 and
arm but SIGTRAP on arm64. Breakpad does not handle SIGTRAP (yet).
Temporarily reverting this CL until SIGTRAP support for breakpad lands.


BUG=599867,614865

Original issue's description:
> In official builds, let CHECK(false) crash instead of calling BreakDebugger.
> 
> This should save some binary size and make things a bit faster, without ill
> effects.
> 
> See bug comment 15, and brettw's and my comments on
> "[blink-dev] Update of wtf/Assertions.h, and ASSERT macros deprecation"
> 
> BUG=599867
> 
> Committed: https://crrev.com/481a8ec8b24df24795c63fd4ec26f3670d516db8
> Cr-Commit-Position: refs/heads/master@{#394035}

TBR=danakj@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=599867
==========

[commit-bot: I haz the power, 2016-06-06 19:14:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-06 19:16:10]

Description was changed from

==========
Revert of In official builds, let CHECK(false) crash instead of calling
BreakDebugger. (patchset #2 id:20001 of
https://codereview.chromium.org/1982123002/ )

Reason for revert:
Unfortunately crrev.com/1982123002 causes loss of
crash reports on Android arm64 (and supposedly also CrOS).
This is because __builtin_trap() raises a SIGILL on x86 and
arm but SIGTRAP on arm64. Breakpad does not handle SIGTRAP (yet).
Temporarily reverting this CL until SIGTRAP support for breakpad lands.


BUG=599867,614865

Original issue's description:
> In official builds, let CHECK(false) crash instead of calling BreakDebugger.
> 
> This should save some binary size and make things a bit faster, without ill
> effects.
> 
> See bug comment 15, and brettw's and my comments on
> "[blink-dev] Update of wtf/Assertions.h, and ASSERT macros deprecation"
> 
> BUG=599867
> 
> Committed: https://crrev.com/481a8ec8b24df24795c63fd4ec26f3670d516db8
> Cr-Commit-Position: refs/heads/master@{#394035}

TBR=danakj@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=599867
==========

to

==========
Revert of In official builds, let CHECK(false) crash instead of calling
BreakDebugger. (patchset #2 id:20001 of
https://codereview.chromium.org/1982123002/ )

Reason for revert:
Unfortunately crrev.com/1982123002 causes loss of
crash reports on Android arm64 (and supposedly also CrOS).
This is because __builtin_trap() raises a SIGILL on x86 and
arm but SIGTRAP on arm64. Breakpad does not handle SIGTRAP (yet).
Temporarily reverting this CL until SIGTRAP support for breakpad lands.

BUG=599867,614865

Original issue's description:
> In official builds, let CHECK(false) crash instead of calling BreakDebugger.
>
> This should save some binary size and make things a bit faster, without ill
> effects.
>
> See bug comment 15, and brettw's and my comments on
> "[blink-dev] Update of wtf/Assertions.h, and ASSERT macros deprecation"
>
> BUG=599867
>
> Committed: https://crrev.com/481a8ec8b24df24795c63fd4ec26f3670d516db8
> Cr-Commit-Position: refs/heads/master@{#394035}

TBR=danakj@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=599867

Committed: https://crrev.com/6ff194f572f62ff4989aaadc9af6616eb78b954a
Cr-Commit-Position: refs/heads/master@{#398084}
==========

[commit-bot: I haz the power, 2016-06-06 19:16:11]

Patchset 1 (id:??) landed as
https://crrev.com/6ff194f572f62ff4989aaadc9af6616eb78b954a
Cr-Commit-Position: refs/heads/master@{#398084}

[Primiano Tucci (use gerrit), 2016-07-06 17:23:46]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2125923002/ by primiano@chromium.org.

The reason for reverting is: The SIGTRAP support has landed in breakpad and the
crash reports seem to flow through.
Should now be safe to rely on __builtin_trap on arm64..