Make the focus, caret, and cursor highlights fade out.

Make the focus, caret, and cursor highlights fade out.

To minimize the distraction from having these highlights on the screen,
make all of them behave similarly to the cursor highlight and just fade
in quickly when changing, and then fade out slowly.

Because this conflicts with how the focus ring behaves when spoken
feedback is on, add a separate mode for that focus ring behavior.

BUG=314889
Committed: https://crrev.com/42e4b00878c001f329489533ecd4fa8823c47717
Cr-Commit-Position: refs/heads/master@{#398668}

[dmazzoni, 2016-06-08 17:52:24]

dmazzoni@chromium.org changed reviewers:
+ xiyuan@chromium.org

[xiyuan, 2016-06-08 18:17:52]

lgtm

https://codereview.chromium.org/2046563009/diff/1/chrome/browser/chromeos/ui/...
File chrome/browser/chromeos/ui/accessibility_focus_ring_controller.cc (right):

https://codereview.chromium.org/2046563009/diff/1/chrome/browser/chromeos/ui/...
chrome/browser/chromeos/ui/accessibility_focus_ring_controller.cc:67:
AccessibilityFocusRingController::FADE_OUT_FOCUS_RING) {
nit: initialize in header?

[dmazzoni, 2016-06-08 20:00:34]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-06-08 20:00:35]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2046563009/#ps20001
(title: "Move initialization to header, fix compile error")

[commit-bot: I haz the power, 2016-06-08 20:01:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2046563009/20001

[dmazzoni, 2016-06-08 20:01:23]

https://codereview.chromium.org/2046563009/diff/1/chrome/browser/chromeos/ui/...
File chrome/browser/chromeos/ui/accessibility_focus_ring_controller.cc (right):

https://codereview.chromium.org/2046563009/diff/1/chrome/browser/chromeos/ui/...
chrome/browser/chromeos/ui/accessibility_focus_ring_controller.cc:67:
AccessibilityFocusRingController::FADE_OUT_FOCUS_RING) {
On 2016/06/08 18:17:52, xiyuan wrote:
> nit: initialize in header?

Done.

[commit-bot: I haz the power, 2016-06-08 20:58:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-08 21:03:00]

Description was changed from

==========
Make the focus, caret, and cursor highlights fade out.

To minimize the distraction from having these highlights on the screen,
make all of them behave similarly to the cursor highlight and just fade
in quickly when changing, and then fade out slowly.

Because this conflicts with how the focus ring behaves when spoken
feedback is on, add a separate mode for that focus ring behavior.

BUG=314889
==========

to

==========
Make the focus, caret, and cursor highlights fade out.

To minimize the distraction from having these highlights on the screen,
make all of them behave similarly to the cursor highlight and just fade
in quickly when changing, and then fade out slowly.

Because this conflicts with how the focus ring behaves when spoken
feedback is on, add a separate mode for that focus ring behavior.

BUG=314889

Committed: https://crrev.com/42e4b00878c001f329489533ecd4fa8823c47717
Cr-Commit-Position: refs/heads/master@{#398668}
==========

[commit-bot: I haz the power, 2016-06-08 21:03:01]

Patchset 2 (id:??) landed as
https://crrev.com/42e4b00878c001f329489533ecd4fa8823c47717
Cr-Commit-Position: refs/heads/master@{#398668}