Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: chrome/browser/chromeos/accessibility/accessibility_highlight_manager.cc

Issue 2046563009: Make the focus, caret, and cursor highlights fade out. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move initialization to header, fix compile error Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/accessibility/accessibility_highlight_manager.cc
diff --git a/chrome/browser/chromeos/accessibility/accessibility_highlight_manager.cc b/chrome/browser/chromeos/accessibility/accessibility_highlight_manager.cc
index 786de38d8aa069692678c318866dc4722e772ae8..495843d43d72a99611e15bb9cac8f0f1e05d2c24 100644
--- a/chrome/browser/chromeos/accessibility/accessibility_highlight_manager.cc
+++ b/chrome/browser/chromeos/accessibility/accessibility_highlight_manager.cc
@@ -54,7 +54,8 @@ AccessibilityHighlightManager::~AccessibilityHighlightManager() {
shell->RemovePreTargetHandler(this);
AccessibilityFocusRingController::GetInstance()->SetFocusRing(
- std::vector<gfx::Rect>());
+ std::vector<gfx::Rect>(),
+ AccessibilityFocusRingController::FADE_OUT_FOCUS_RING);
AccessibilityFocusRingController::GetInstance()->SetCaretRing(
OffscreenPoint());
AccessibilityFocusRingController::GetInstance()->SetCursorRing(
@@ -126,16 +127,21 @@ void AccessibilityHighlightManager::UpdateFocusAndCaretHighlights() {
// both are visible.
if (caret_ && caret_visible_) {
controller->SetCaretRing(caret_point_);
- controller->SetFocusRing(std::vector<gfx::Rect>());
+ controller->SetFocusRing(
+ std::vector<gfx::Rect>(),
+ AccessibilityFocusRingController::FADE_OUT_FOCUS_RING);
} else if (focus_) {
controller->SetCaretRing(OffscreenPoint());
std::vector<gfx::Rect> rects;
if (!focus_rect_.IsEmpty())
rects.push_back(focus_rect_);
- controller->SetFocusRing(rects);
+ controller->SetFocusRing(
+ rects, AccessibilityFocusRingController::FADE_OUT_FOCUS_RING);
} else {
controller->SetCaretRing(OffscreenPoint());
- controller->SetFocusRing(std::vector<gfx::Rect>());
+ controller->SetFocusRing(
+ std::vector<gfx::Rect>(),
+ AccessibilityFocusRingController::FADE_OUT_FOCUS_RING);
}
}

Powered by Google App Engine
This is Rietveld 408576698