Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2046563008: Revert of [heap] Unregister shrinked large object memory from chunk map. (Closed)

Created:
4 years, 6 months ago by Hannes Payer (out of office)
Modified:
4 years, 6 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Unregister shrinked large object memory from chunk map. (patchset #6 id:100001 of https://codereview.chromium.org/2046953002/ ) Reason for revert: Revert because uncommit of lo is broken. Original issue's description: > [heap] Unregister shrinked large object memory from chunk map. > > BUG=chromium:617883 > LOG=n > > Committed: https://crrev.com/2b38d3121b5fd0e409cdda0071fa2e0ec2846ab2 > Cr-Commit-Position: refs/heads/master@{#36793} TBR=ulan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:617883 Committed: https://crrev.com/56a9e33802c08563495ce0ef5aa47025fe8f594a Cr-Commit-Position: refs/heads/master@{#36806}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -49 lines) Patch
M src/hashmap.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/heap/spaces.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/heap/spaces.cc View 4 chunks +21 lines, -31 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Hannes Payer (out of office)
Created Revert of [heap] Unregister shrinked large object memory from chunk map.
4 years, 6 months ago (2016-06-08 06:11:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046563008/1
4 years, 6 months ago (2016-06-08 06:11:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 06:11:46 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 06:13:07 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56a9e33802c08563495ce0ef5aa47025fe8f594a
Cr-Commit-Position: refs/heads/master@{#36806}

Powered by Google App Engine
This is Rietveld 408576698