Resubmission of sashab's patch: Make CSSComputedStyledeclaration::getPropertyCSSValue return const

Resubmission of sashab's patch: Make CSSComputedStyledeclaration::getPropertyCSSValue return const

Make CSSComputedStyledeclaration::getPropertyCSSValue() return a const
CSSValue* instead of a regular CSSValue*. This required changing
CSSStyleDeclaration::getPropertyCSSValueInternal() return a const
CSSValue* as well, and marking CSSValueList::copy() as a const method
(which it already was, it was just missing the const modifier). This is
pre-work for making CSSValueList store const CSSValues.

This patch is mostly mechanical changes, but does contain one logic
change: the static method mergeTextDecorationValues in EditingStyle
needs to be changed since it modifies a CSSValueList that points inside
the mutable style. Instead, the function is changed to take two
CSSValueLists and return a new one, and the callsite is changed to
replace the old CSSValueList with the new one in the style rather than
modifying the old CSSValueList in-place.

Original patch is here:
https://codereview.chromium.org/2034013002

BUG=526586
Committed: https://crrev.com/897d431a873f7369215769d55b83257b78b28671
Cr-Commit-Position: refs/heads/master@{#398235}

[meade_UTC10, 2016-06-07 00:53:18]

Description was changed from

==========
Resubmission of sashab's patch: Make
CSSComputedStyledeclaration::getPropertyCSSValue return const

Make CSSComputedStyledeclaration::getPropertyCSSValue() return a const
CSSValue* instead of a regular CSSValue*. This required changing
CSSStyleDeclaration::getPropertyCSSValueInternal() return a const
CSSValue* as well, and marking CSSValueList::copy() as a const method
(which it already was, it was just missing the const modifier). This is
pre-work for making CSSValueList store const CSSValues.

This patch is mostly mechanical changes, but does contain one logic
change: the static method mergeTextDecorationValues in EditingStyle
needs to be changed since it modifies a CSSValueList that points inside
the mutable style. Instead, the function is changed to take two
CSSValueLists and return a new one, and the callsite is changed to
replace the old CSSValueList with the new one in the style rather than
modifying the old CSSValueList in-place.

BUG=526586
==========

to

==========
Resubmission of sashab's patch: Make
CSSComputedStyledeclaration::getPropertyCSSValue return const

Make CSSComputedStyledeclaration::getPropertyCSSValue() return a const
CSSValue* instead of a regular CSSValue*. This required changing
CSSStyleDeclaration::getPropertyCSSValueInternal() return a const
CSSValue* as well, and marking CSSValueList::copy() as a const method
(which it already was, it was just missing the const modifier). This is
pre-work for making CSSValueList store const CSSValues.

This patch is mostly mechanical changes, but does contain one logic
change: the static method mergeTextDecorationValues in EditingStyle
needs to be changed since it modifies a CSSValueList that points inside
the mutable style. Instead, the function is changed to take two
CSSValueLists and return a new one, and the callsite is changed to
replace the old CSSValueList with the new one in the style rather than
modifying the old CSSValueList in-place.

Original patch is here:
https://codereview.chromium.org/2034013002

BUG=526586
==========

[meade_UTC10, 2016-06-07 01:07:51]

meade@chromium.org changed reviewers:
+ haraken@chromium.org, timloh@chromium.org, yukishiino@chromium.org

[meade_UTC10, 2016-06-07 01:07:51]

Hi Haraken, Yuki, Tim,

This is a re-land of Sasha's patch from yesterday that conflicted with my patch
when we landed them close together. There is one small change from the original
patch in third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp
that fixes this.

Thank you!
Eddy

[haraken, 2016-06-07 01:19:53]

LGTM

[meade_UTC10, 2016-06-07 04:34:14]

The CQ bit was checked by meade@chromium.org

[commit-bot: I haz the power, 2016-06-07 04:34:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2046463003/20001

[Yuki, 2016-06-07 05:19:10]

lgtm

[commit-bot: I haz the power, 2016-06-07 05:29:44]

Description was changed from

==========
Resubmission of sashab's patch: Make
CSSComputedStyledeclaration::getPropertyCSSValue return const

Make CSSComputedStyledeclaration::getPropertyCSSValue() return a const
CSSValue* instead of a regular CSSValue*. This required changing
CSSStyleDeclaration::getPropertyCSSValueInternal() return a const
CSSValue* as well, and marking CSSValueList::copy() as a const method
(which it already was, it was just missing the const modifier). This is
pre-work for making CSSValueList store const CSSValues.

This patch is mostly mechanical changes, but does contain one logic
change: the static method mergeTextDecorationValues in EditingStyle
needs to be changed since it modifies a CSSValueList that points inside
the mutable style. Instead, the function is changed to take two
CSSValueLists and return a new one, and the callsite is changed to
replace the old CSSValueList with the new one in the style rather than
modifying the old CSSValueList in-place.

Original patch is here:
https://codereview.chromium.org/2034013002

BUG=526586
==========

to

==========
Resubmission of sashab's patch: Make
CSSComputedStyledeclaration::getPropertyCSSValue return const

Make CSSComputedStyledeclaration::getPropertyCSSValue() return a const
CSSValue* instead of a regular CSSValue*. This required changing
CSSStyleDeclaration::getPropertyCSSValueInternal() return a const
CSSValue* as well, and marking CSSValueList::copy() as a const method
(which it already was, it was just missing the const modifier). This is
pre-work for making CSSValueList store const CSSValues.

This patch is mostly mechanical changes, but does contain one logic
change: the static method mergeTextDecorationValues in EditingStyle
needs to be changed since it modifies a CSSValueList that points inside
the mutable style. Instead, the function is changed to take two
CSSValueLists and return a new one, and the callsite is changed to
replace the old CSSValueList with the new one in the style rather than
modifying the old CSSValueList in-place.

Original patch is here:
https://codereview.chromium.org/2034013002

BUG=526586
==========

[commit-bot: I haz the power, 2016-06-07 05:29:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-07 05:31:59]

Description was changed from

==========
Resubmission of sashab's patch: Make
CSSComputedStyledeclaration::getPropertyCSSValue return const

Make CSSComputedStyledeclaration::getPropertyCSSValue() return a const
CSSValue* instead of a regular CSSValue*. This required changing
CSSStyleDeclaration::getPropertyCSSValueInternal() return a const
CSSValue* as well, and marking CSSValueList::copy() as a const method
(which it already was, it was just missing the const modifier). This is
pre-work for making CSSValueList store const CSSValues.

This patch is mostly mechanical changes, but does contain one logic
change: the static method mergeTextDecorationValues in EditingStyle
needs to be changed since it modifies a CSSValueList that points inside
the mutable style. Instead, the function is changed to take two
CSSValueLists and return a new one, and the callsite is changed to
replace the old CSSValueList with the new one in the style rather than
modifying the old CSSValueList in-place.

Original patch is here:
https://codereview.chromium.org/2034013002

BUG=526586
==========

to

==========
Resubmission of sashab's patch: Make
CSSComputedStyledeclaration::getPropertyCSSValue return const

Make CSSComputedStyledeclaration::getPropertyCSSValue() return a const
CSSValue* instead of a regular CSSValue*. This required changing
CSSStyleDeclaration::getPropertyCSSValueInternal() return a const
CSSValue* as well, and marking CSSValueList::copy() as a const method
(which it already was, it was just missing the const modifier). This is
pre-work for making CSSValueList store const CSSValues.

This patch is mostly mechanical changes, but does contain one logic
change: the static method mergeTextDecorationValues in EditingStyle
needs to be changed since it modifies a CSSValueList that points inside
the mutable style. Instead, the function is changed to take two
CSSValueLists and return a new one, and the callsite is changed to
replace the old CSSValueList with the new one in the style rather than
modifying the old CSSValueList in-place.

Original patch is here:
https://codereview.chromium.org/2034013002

BUG=526586

Committed: https://crrev.com/897d431a873f7369215769d55b83257b78b28671
Cr-Commit-Position: refs/heads/master@{#398235}
==========

[commit-bot: I haz the power, 2016-06-07 05:32:00]

Patchset 2 (id:??) landed as
https://crrev.com/897d431a873f7369215769d55b83257b78b28671
Cr-Commit-Position: refs/heads/master@{#398235}