Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2046453003:
Blimp: Removed sending redundant RESIZE message to engine (Closed)
|
Created:
4 years, 6 months ago by shaktisahu Modified:
4 years, 6 months ago CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionBlimp: Removed sending redundant RESIZE message to engine
At the startup, the blimp client sends a RESIZE message to the engine
with size 0x0 which is not useful for the engine. Removed sending of
this message. The correct display size is sent later when the native
android view inflates to its correct size.
BUG=617278
Committed: https://crrev.com/0e561c56fa3158e4a52136589f46ad60f4aa0c21
Cr-Commit-Position: refs/heads/master@{#398332}
Patch Set 1 #
Messages
Total messages: 20 (10 generated)
shaktisahu@chromium.org changed reviewers: + haibinlu@chromium.org
lgtm
The CQ bit was checked by shaktisahu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046453003/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== Blimp: Removed sending redundant RESIZE message to engine At the startup, the blimp client sends a RESIZE message to the engine with size 0x0 which is not useful for the engine. Removed sending of this message. The correct display size is sent later when the native android view inflates to its correct size. BUG=617278 ========== to ========== Blimp: Removed sending redundant RESIZE message to engine At the startup, the blimp client sends a RESIZE message to the engine with size 0x0 which is not useful for the engine. Removed sending of this message. The correct display size is sent later when the native android view inflates to its correct size. BUG=617278 ==========
shaktisahu@chromium.org changed reviewers: + nyquist@chromium.org
lgtm
The CQ bit was checked by shaktisahu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046453003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_clang on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by shaktisahu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046453003/1
Message was sent while issue was closed.
Description was changed from ========== Blimp: Removed sending redundant RESIZE message to engine At the startup, the blimp client sends a RESIZE message to the engine with size 0x0 which is not useful for the engine. Removed sending of this message. The correct display size is sent later when the native android view inflates to its correct size. BUG=617278 ========== to ========== Blimp: Removed sending redundant RESIZE message to engine At the startup, the blimp client sends a RESIZE message to the engine with size 0x0 which is not useful for the engine. Removed sending of this message. The correct display size is sent later when the native android view inflates to its correct size. BUG=617278 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Blimp: Removed sending redundant RESIZE message to engine At the startup, the blimp client sends a RESIZE message to the engine with size 0x0 which is not useful for the engine. Removed sending of this message. The correct display size is sent later when the native android view inflates to its correct size. BUG=617278 ========== to ========== Blimp: Removed sending redundant RESIZE message to engine At the startup, the blimp client sends a RESIZE message to the engine with size 0x0 which is not useful for the engine. Removed sending of this message. The correct display size is sent later when the native android view inflates to its correct size. BUG=617278 Committed: https://crrev.com/0e561c56fa3158e4a52136589f46ad60f4aa0c21 Cr-Commit-Position: refs/heads/master@{#398332} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/0e561c56fa3158e4a52136589f46ad60f4aa0c21 Cr-Commit-Position: refs/heads/master@{#398332} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
