Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2566)

Unified Diff: blimp/client/app/android/java/src/org/chromium/blimp/session/TabControlFeature.java

Issue 2046453003: Blimp: Removed sending redundant RESIZE message to engine (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/app/android/java/src/org/chromium/blimp/session/TabControlFeature.java
diff --git a/blimp/client/app/android/java/src/org/chromium/blimp/session/TabControlFeature.java b/blimp/client/app/android/java/src/org/chromium/blimp/session/TabControlFeature.java
index 4078f0880dd14a5d09ef7405515a4c1e229af7a0..4cbbde6bb22928580c192b3348939dbae0d27b98 100644
--- a/blimp/client/app/android/java/src/org/chromium/blimp/session/TabControlFeature.java
+++ b/blimp/client/app/android/java/src/org/chromium/blimp/session/TabControlFeature.java
@@ -14,8 +14,6 @@ import org.chromium.base.annotations.JNINamespace;
*/
@JNINamespace("blimp::client")
public class TabControlFeature implements View.OnLayoutChangeListener {
- private final float mDpToPx;
-
private View mContentAreaView;
private long mNativeTabControlFeatureAndroidPtr;
@@ -33,12 +31,7 @@ public class TabControlFeature implements View.OnLayoutChangeListener {
public TabControlFeature(BlimpClientSession blimpClientSession, View contentAreaView) {
mContentAreaView = contentAreaView;
mContentAreaView.addOnLayoutChangeListener(this);
- mDpToPx = mContentAreaView.getContext().getResources().getDisplayMetrics().density;
mNativeTabControlFeatureAndroidPtr = nativeInit(blimpClientSession);
-
- // Push down the current size of the content area view.
- nativeOnContentAreaSizeChanged(mNativeTabControlFeatureAndroidPtr,
- mContentAreaView.getWidth(), mContentAreaView.getHeight(), mDpToPx);
}
/**
@@ -63,7 +56,8 @@ public class TabControlFeature implements View.OnLayoutChangeListener {
int oldLeft, int oldTop, int oldRight, int oldBottom) {
if (mNativeTabControlFeatureAndroidPtr == 0) return;
nativeOnContentAreaSizeChanged(mNativeTabControlFeatureAndroidPtr, right - left,
- bottom - top, mDpToPx);
+ bottom - top,
+ mContentAreaView.getContext().getResources().getDisplayMetrics().density);
}
private native long nativeInit(BlimpClientSession blimpClientSession);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698