Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: chrome/browser/banners/app_banner_debug_log.cc

Issue 2046423003: Make OutputDeveloperMessageCode an enum class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into create_webapk_requirements_enum_class Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/banners/app_banner_debug_log.h ('k') | chrome/browser/banners/app_banner_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_debug_log.cc
diff --git a/chrome/browser/banners/app_banner_debug_log.cc b/chrome/browser/banners/app_banner_debug_log.cc
index dac19e0351a7961a054f98eb967872259871de1e..997a5d992502f8003a4462f4eeb1fb641c3a1021 100644
--- a/chrome/browser/banners/app_banner_debug_log.cc
+++ b/chrome/browser/banners/app_banner_debug_log.cc
@@ -67,58 +67,58 @@ void OutputDeveloperNotShownMessage(content::WebContents* web_contents,
const char* pattern;
content::ConsoleMessageLevel severity = content::CONSOLE_MESSAGE_LEVEL_ERROR;
switch (code) {
- case kRendererRequestCancel:
+ case OutputDeveloperMessageCode::kRendererRequestCancel:
pattern = kRendererRequestCancelMessage;
severity = content::CONSOLE_MESSAGE_LEVEL_LOG;
break;
- case kManifestEmpty:
+ case OutputDeveloperMessageCode::kManifestEmpty:
pattern = kManifestEmptyMessage;
break;
- case kNoManifest:
+ case OutputDeveloperMessageCode::kNoManifest:
pattern = kNoManifestMessage;
break;
- case kNoIconMatchingRequirements:
+ case OutputDeveloperMessageCode::kNoIconMatchingRequirements:
pattern = kNoIconMatchingRequirementsMessage;
break;
- case kCannotDownloadIcon:
+ case OutputDeveloperMessageCode::kCannotDownloadIcon:
pattern = kCannotDownloadIconMessage;
break;
- case kNoMatchingServiceWorker:
+ case OutputDeveloperMessageCode::kNoMatchingServiceWorker:
pattern = kNoMatchingServiceWorkerMessage;
break;
- case kNoIconAvailable:
+ case OutputDeveloperMessageCode::kNoIconAvailable:
pattern = kNoIconAvailableMessage;
break;
- case kUserNavigatedBeforeBannerShown:
+ case OutputDeveloperMessageCode::kUserNavigatedBeforeBannerShown:
pattern = kUserNavigatedBeforeBannerShownMessage;
severity = content::CONSOLE_MESSAGE_LEVEL_WARNING;
break;
- case kStartURLNotValid:
+ case OutputDeveloperMessageCode::kStartURLNotValid:
pattern = kStartURLNotValidMessage;
break;
- case kManifestDisplayStandaloneFullscreen:
+ case OutputDeveloperMessageCode::kManifestDisplayStandaloneFullscreen:
pattern = kManifestDisplayStandaloneFullscreenMessage;
break;
- case kManifestMissingNameOrShortName:
+ case OutputDeveloperMessageCode::kManifestMissingNameOrShortName:
pattern = kManifestMissingNameOrShortNameMessage;
break;
- case kManifestMissingSuitableIcon:
+ case OutputDeveloperMessageCode::kManifestMissingSuitableIcon:
pattern = kManifestMissingSuitableIconMessage;
break;
- case kNotLoadedInMainFrame:
+ case OutputDeveloperMessageCode::kNotLoadedInMainFrame:
pattern = kNotLoadedInMainFrameMessage;
break;
- case kNotServedFromSecureOrigin:
+ case OutputDeveloperMessageCode::kNotServedFromSecureOrigin:
pattern = kNotServedFromSecureOriginMessage;
break;
- case kIgnoredNotSupportedOnAndroid:
+ case OutputDeveloperMessageCode::kIgnoredNotSupportedOnAndroid:
pattern = kIgnoredNotSupportedOnAndroidMessage;
severity = content::CONSOLE_MESSAGE_LEVEL_WARNING;
break;
- case kIgnoredNoId:
+ case OutputDeveloperMessageCode::kIgnoredNoId:
pattern = kIgnoredNoIdMessage;
break;
- case kIgnoredIdsDoNotMatch:
+ case OutputDeveloperMessageCode::kIgnoredIdsDoNotMatch:
pattern = kIgnoredIdsDoNotMatchMessage;
break;
default:
« no previous file with comments | « chrome/browser/banners/app_banner_debug_log.h ('k') | chrome/browser/banners/app_banner_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698