Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/browser/banners/app_banner_debug_log.cc

Issue 2046423003: Make OutputDeveloperMessageCode an enum class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into create_webapk_requirements_enum_class Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/banners/app_banner_debug_log.h ('k') | chrome/browser/banners/app_banner_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/banners/app_banner_debug_log.h" 5 #include "chrome/browser/banners/app_banner_debug_log.h"
6 6
7 #include "base/strings/stringprintf.h" 7 #include "base/strings/stringprintf.h"
8 #include "content/public/browser/render_frame_host.h" 8 #include "content/public/browser/render_frame_host.h"
9 #include "content/public/browser/web_contents.h" 9 #include "content/public/browser/web_contents.h"
10 10
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 void OutputDeveloperNotShownMessage(content::WebContents* web_contents, 60 void OutputDeveloperNotShownMessage(content::WebContents* web_contents,
61 OutputDeveloperMessageCode code, 61 OutputDeveloperMessageCode code,
62 const std::string& param, 62 const std::string& param,
63 bool is_debug_mode) { 63 bool is_debug_mode) {
64 if (!is_debug_mode || !web_contents) 64 if (!is_debug_mode || !web_contents)
65 return; 65 return;
66 66
67 const char* pattern; 67 const char* pattern;
68 content::ConsoleMessageLevel severity = content::CONSOLE_MESSAGE_LEVEL_ERROR; 68 content::ConsoleMessageLevel severity = content::CONSOLE_MESSAGE_LEVEL_ERROR;
69 switch (code) { 69 switch (code) {
70 case kRendererRequestCancel: 70 case OutputDeveloperMessageCode::kRendererRequestCancel:
71 pattern = kRendererRequestCancelMessage; 71 pattern = kRendererRequestCancelMessage;
72 severity = content::CONSOLE_MESSAGE_LEVEL_LOG; 72 severity = content::CONSOLE_MESSAGE_LEVEL_LOG;
73 break; 73 break;
74 case kManifestEmpty: 74 case OutputDeveloperMessageCode::kManifestEmpty:
75 pattern = kManifestEmptyMessage; 75 pattern = kManifestEmptyMessage;
76 break; 76 break;
77 case kNoManifest: 77 case OutputDeveloperMessageCode::kNoManifest:
78 pattern = kNoManifestMessage; 78 pattern = kNoManifestMessage;
79 break; 79 break;
80 case kNoIconMatchingRequirements: 80 case OutputDeveloperMessageCode::kNoIconMatchingRequirements:
81 pattern = kNoIconMatchingRequirementsMessage; 81 pattern = kNoIconMatchingRequirementsMessage;
82 break; 82 break;
83 case kCannotDownloadIcon: 83 case OutputDeveloperMessageCode::kCannotDownloadIcon:
84 pattern = kCannotDownloadIconMessage; 84 pattern = kCannotDownloadIconMessage;
85 break; 85 break;
86 case kNoMatchingServiceWorker: 86 case OutputDeveloperMessageCode::kNoMatchingServiceWorker:
87 pattern = kNoMatchingServiceWorkerMessage; 87 pattern = kNoMatchingServiceWorkerMessage;
88 break; 88 break;
89 case kNoIconAvailable: 89 case OutputDeveloperMessageCode::kNoIconAvailable:
90 pattern = kNoIconAvailableMessage; 90 pattern = kNoIconAvailableMessage;
91 break; 91 break;
92 case kUserNavigatedBeforeBannerShown: 92 case OutputDeveloperMessageCode::kUserNavigatedBeforeBannerShown:
93 pattern = kUserNavigatedBeforeBannerShownMessage; 93 pattern = kUserNavigatedBeforeBannerShownMessage;
94 severity = content::CONSOLE_MESSAGE_LEVEL_WARNING; 94 severity = content::CONSOLE_MESSAGE_LEVEL_WARNING;
95 break; 95 break;
96 case kStartURLNotValid: 96 case OutputDeveloperMessageCode::kStartURLNotValid:
97 pattern = kStartURLNotValidMessage; 97 pattern = kStartURLNotValidMessage;
98 break; 98 break;
99 case kManifestDisplayStandaloneFullscreen: 99 case OutputDeveloperMessageCode::kManifestDisplayStandaloneFullscreen:
100 pattern = kManifestDisplayStandaloneFullscreenMessage; 100 pattern = kManifestDisplayStandaloneFullscreenMessage;
101 break; 101 break;
102 case kManifestMissingNameOrShortName: 102 case OutputDeveloperMessageCode::kManifestMissingNameOrShortName:
103 pattern = kManifestMissingNameOrShortNameMessage; 103 pattern = kManifestMissingNameOrShortNameMessage;
104 break; 104 break;
105 case kManifestMissingSuitableIcon: 105 case OutputDeveloperMessageCode::kManifestMissingSuitableIcon:
106 pattern = kManifestMissingSuitableIconMessage; 106 pattern = kManifestMissingSuitableIconMessage;
107 break; 107 break;
108 case kNotLoadedInMainFrame: 108 case OutputDeveloperMessageCode::kNotLoadedInMainFrame:
109 pattern = kNotLoadedInMainFrameMessage; 109 pattern = kNotLoadedInMainFrameMessage;
110 break; 110 break;
111 case kNotServedFromSecureOrigin: 111 case OutputDeveloperMessageCode::kNotServedFromSecureOrigin:
112 pattern = kNotServedFromSecureOriginMessage; 112 pattern = kNotServedFromSecureOriginMessage;
113 break; 113 break;
114 case kIgnoredNotSupportedOnAndroid: 114 case OutputDeveloperMessageCode::kIgnoredNotSupportedOnAndroid:
115 pattern = kIgnoredNotSupportedOnAndroidMessage; 115 pattern = kIgnoredNotSupportedOnAndroidMessage;
116 severity = content::CONSOLE_MESSAGE_LEVEL_WARNING; 116 severity = content::CONSOLE_MESSAGE_LEVEL_WARNING;
117 break; 117 break;
118 case kIgnoredNoId: 118 case OutputDeveloperMessageCode::kIgnoredNoId:
119 pattern = kIgnoredNoIdMessage; 119 pattern = kIgnoredNoIdMessage;
120 break; 120 break;
121 case kIgnoredIdsDoNotMatch: 121 case OutputDeveloperMessageCode::kIgnoredIdsDoNotMatch:
122 pattern = kIgnoredIdsDoNotMatchMessage; 122 pattern = kIgnoredIdsDoNotMatchMessage;
123 break; 123 break;
124 default: 124 default:
125 NOTREACHED(); 125 NOTREACHED();
126 return; 126 return;
127 } 127 }
128 std::string message = param.empty() ? 128 std::string message = param.empty() ?
129 pattern : base::StringPrintf(pattern, param.c_str()); 129 pattern : base::StringPrintf(pattern, param.c_str());
130 web_contents->GetMainFrame()->AddMessageToConsole( 130 web_contents->GetMainFrame()->AddMessageToConsole(
131 severity, "App banner not shown: " + message); 131 severity, "App banner not shown: " + message);
132 132
133 } 133 }
134 134
135 } // namespace banners 135 } // namespace banners
OLDNEW
« no previous file with comments | « chrome/browser/banners/app_banner_debug_log.h ('k') | chrome/browser/banners/app_banner_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698