Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3450)

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 2046423003: Make OutputDeveloperMessageCode an enum class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into create_webapk_requirements_enum_class Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_manager_android.cc
diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc
index 5556b543d17f8c9bbd6cef373ca76d9f5ff2808b..e157fcb3f2c44cdbdce0cb81aeed138a3c46a5d8 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.cc
+++ b/chrome/browser/android/banners/app_banner_manager_android.cc
@@ -72,7 +72,9 @@ bool AppBannerManagerAndroid::HandleNonWebApp(const std::string& platform,
std::string id_from_app_url = ExtractQueryValueForName(url, kIdName);
if (id_from_app_url.size() && id != id_from_app_url) {
banners::OutputDeveloperNotShownMessage(
- web_contents(), banners::kIgnoredIdsDoNotMatch, is_debug_mode);
+ web_contents(),
+ banners::OutputDeveloperMessageCode::kIgnoredIdsDoNotMatch,
+ is_debug_mode);
return false;
}
@@ -104,13 +106,15 @@ bool AppBannerManagerAndroid::CheckPlatformAndId(const std::string& platform,
bool is_debug_mode) {
if (platform != kPlayPlatform) {
banners::OutputDeveloperNotShownMessage(
- web_contents(), banners::kIgnoredNotSupportedOnAndroid, platform,
- is_debug_mode);
+ web_contents(),
+ banners::OutputDeveloperMessageCode::kIgnoredNotSupportedOnAndroid,
+ platform, is_debug_mode);
return false;
}
if (id.empty()) {
banners::OutputDeveloperNotShownMessage(
- web_contents(), banners::kIgnoredNoId, is_debug_mode);
+ web_contents(), banners::OutputDeveloperMessageCode::kIgnoredNoId,
+ is_debug_mode);
return false;
}
return true;
@@ -123,7 +127,8 @@ bool AppBannerManagerAndroid::CheckFetcherMatchesContents(bool is_debug_mode) {
if (!data_fetcher() ||
data_fetcher()->validated_url() != web_contents()->GetURL()) {
banners::OutputDeveloperNotShownMessage(
- web_contents(), banners::kUserNavigatedBeforeBannerShown,
+ web_contents(),
+ banners::OutputDeveloperMessageCode::kUserNavigatedBeforeBannerShown,
is_debug_mode);
return false;
}

Powered by Google App Engine
This is Rietveld 408576698