Make OutputDeveloperMessageCode an enum class

chrome/browser/android/banners/app_banner_manager_android.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/banners/app_banner_manager_android.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "chrome/browser/android/banners/app_banner_data_fetcher_android.h"
 #include "chrome/browser/android/shortcut_helper.h"
@@ skipping 54 matching lines @@
 
   // Send the info to the Java side to get info about the app.
   JNIEnv* env = base::android::AttachCurrentThread();
   ScopedJavaLocalRef<jobject> jobj = weak_java_banner_view_manager_.get(env);
   if (jobj.is_null())
     return false;
 
   std::string id_from_app_url = ExtractQueryValueForName(url, kIdName);
   if (id_from_app_url.size() && id != id_from_app_url) {
     banners::OutputDeveloperNotShownMessage(
-        web_contents(), banners::kIgnoredIdsDoNotMatch, is_debug_mode);
+        web_contents(),
+        banners::OutputDeveloperMessageCode::kIgnoredIdsDoNotMatch,
+        is_debug_mode);
     return false;
   }
 
   std::string referrer =
       ExtractQueryValueForName(url, kReferrerName);
 
   // Attach the chrome_inline referrer value, prefixed with "&" if the referrer
   // is non empty.
   if (referrer.empty())
     referrer = kPlayInlineReferrer;
@@ skipping 11 matching lines @@
       jpackage.obj(), jreferrer.obj(),
       ShortcutHelper::GetIdealHomescreenIconSizeInDp());
   return true;
 }
 
 bool AppBannerManagerAndroid::CheckPlatformAndId(const std::string& platform,
                                                  const std::string& id,
                                                  bool is_debug_mode) {
   if (platform != kPlayPlatform) {
     banners::OutputDeveloperNotShownMessage(
-        web_contents(), banners::kIgnoredNotSupportedOnAndroid, platform,
-        is_debug_mode);
+        web_contents(),
+        banners::OutputDeveloperMessageCode::kIgnoredNotSupportedOnAndroid,
+        platform, is_debug_mode);
     return false;
   }
   if (id.empty()) {
     banners::OutputDeveloperNotShownMessage(
-        web_contents(), banners::kIgnoredNoId, is_debug_mode);
+        web_contents(), banners::OutputDeveloperMessageCode::kIgnoredNoId,
+        is_debug_mode);
     return false;
   }
   return true;
 }
 
 bool AppBannerManagerAndroid::CheckFetcherMatchesContents(bool is_debug_mode) {
   if (!web_contents())
     return false;
 
   if (!data_fetcher() ||
       data_fetcher()->validated_url() != web_contents()->GetURL()) {
     banners::OutputDeveloperNotShownMessage(
-        web_contents(), banners::kUserNavigatedBeforeBannerShown,
+        web_contents(),
+        banners::OutputDeveloperMessageCode::kUserNavigatedBeforeBannerShown,
         is_debug_mode);
     return false;
   }
   return true;
 }
 
 std::string AppBannerManagerAndroid::ExtractQueryValueForName(
     const GURL& url,
     const std::string& name) {
   url::Component query = url.parsed_for_possibly_invalid_spec().query;
@@ skipping 77 matching lines @@
 
 void SetEngagementWeights(JNIEnv* env,
                           const JavaParamRef<jclass>& clazz,
                           jdouble direct_engagement,
                           jdouble indirect_engagement) {
   AppBannerManager::SetEngagementWeights(direct_engagement,
                                          indirect_engagement);
 }
 
 }  // namespace banners