Autoplay: disable muted video autoplay if data saver is on.

Autoplay: disable muted video autoplay if data saver is on.

BUG=607551
R=avayvod@chromium.org

Committed: https://crrev.com/f8bfcd3507243fd3250f7ef3e2412a495284fcc6
Cr-Commit-Position: refs/heads/master@{#398905}

[mlamouri (slow - plz ping), 2016-06-08 10:55:48]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-08 10:56:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2046403002/1

[commit-bot: I haz the power, 2016-06-08 13:28:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 13:28:12]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[whywhat, 2016-06-08 20:47:37]

lgtm with nits

https://codereview.chromium.org/2046403002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/autoplay-muted-datasaver-off.html
(right):

https://codereview.chromium.org/2046403002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/autoplay-muted-datasaver-off.html:13:
window.internals.settings.setDataSaverEnabled(true);
I think the names of the tests are not in sync with what they're testing:
datasaver-off -> setDataSaverEnabled(false);
datasaver-on -> setDataSaverEnabled(true);

https://codereview.chromium.org/2046403002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/autoplay-muted-datasaver-off.html:15:
async_test(function(t)
consider using promise_test()?

should be something like

promise_test(function(t)
{
    return promise_rejects(t, new NotAllowedError(), function() {
        // setup video
        return video.play();
    });
}, "test that muted videos don't autoplay when DataSaver is on");

[mlamouri (slow - plz ping), 2016-06-09 13:11:47]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2016-06-09 13:11:48]

https://codereview.chromium.org/2046403002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/autoplay-muted-datasaver-off.html
(right):

https://codereview.chromium.org/2046403002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/autoplay-muted-datasaver-off.html:13:
window.internals.settings.setDataSaverEnabled(true);
On 2016/06/08 at 20:47:37, whywhat wrote:
> I think the names of the tests are not in sync with what they're testing:
> datasaver-off -> setDataSaverEnabled(false);
> datasaver-on -> setDataSaverEnabled(true);

Thanks for catching this! :)

https://codereview.chromium.org/2046403002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/autoplay-muted-datasaver-off.html:15:
async_test(function(t)
On 2016/06/08 at 20:47:37, whywhat wrote:
> consider using promise_test()?
> 
> should be something like
> 
> promise_test(function(t)
> {
>     return promise_rejects(t, new NotAllowedError(), function() {
>         // setup video
>         return video.play();
>     });
> }, "test that muted videos don't autoplay when DataSaver is on");

I switched to promise_test.

[mlamouri (slow - plz ping), 2016-06-09 13:11:48]

The patchset sent to the CQ was uploaded after l-g-t-m from avayvod@chromium.org
Link to the patchset: https://codereview.chromium.org/2046403002/#ps20001
(title: "review comments")

[commit-bot: I haz the power, 2016-06-09 13:12:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2046403002/20001

[commit-bot: I haz the power, 2016-06-09 16:33:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-09 16:34:13]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-09 16:35:55]

Description was changed from

==========
Autoplay: disable muted video autoplay if data saver is on.

BUG=607551
R=avayvod@chromium.org
==========

to

==========
Autoplay: disable muted video autoplay if data saver is on.

BUG=607551
R=avayvod@chromium.org

Committed: https://crrev.com/f8bfcd3507243fd3250f7ef3e2412a495284fcc6
Cr-Commit-Position: refs/heads/master@{#398905}
==========

[commit-bot: I haz the power, 2016-06-09 16:35:56]

Patchset 2 (id:??) landed as
https://crrev.com/f8bfcd3507243fd3250f7ef3e2412a495284fcc6
Cr-Commit-Position: refs/heads/master@{#398905}