third_party/WebKit/LayoutTests/media/autoplay-muted-datasaver-off.html - Issue 2046403002: Autoplay: disable muted video autoplay if data saver is on.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/autoplay-muted-datasaver-off.html

Issue 2046403002: Autoplay: disable muted video autoplay if data saver is on. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@video-as-images-flag

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>Test muted autoplay videos interaction with data saver on</title>

	5 <script src="../resources/testharness.js"></script>

	6 <script src="../resources/testharnessreport.js"></script>

	7 <script src="media-file.js"></script>

	8 </head>

	9 <body>

	10 <script>

	11 window.internals.settings.setMediaPlaybackRequiresUserGesture(true);

	12 window.internals.runtimeFlags.videosAsImagesEnabled = true;

	13 window.internals.settings.setDataSaverEnabled(true);
	whywhat 2016/06/08 20:47:37 I think the names of the tests are not in sync wit I think the names of the tests are not in sync with what they're testing: datasaver-off -> setDataSaverEnabled(false); datasaver-on -> setDataSaverEnabled(true); mlamouri (slow - plz ping) 2016/06/09 13:11:48 Thanks for catching this! :) Show quoted text On 2016/06/08 at 20:47:37, whywhat wrote: > I think the names of the tests are not in sync with what they're testing: > datasaver-off -> setDataSaverEnabled(false); > datasaver-on -> setDataSaverEnabled(true); Thanks for catching this! :)
	14

	15 async_test(function(t)
	whywhat 2016/06/08 20:47:37 consider using promise_test()? should be somethin consider using promise_test()? should be something like promise_test(function(t) { return promise_rejects(t, new NotAllowedError(), function() { // setup video return video.play(); }); }, "test that muted videos don't autoplay when DataSaver is on"); mlamouri (slow - plz ping) 2016/06/09 13:11:48 I switched to promise_test. Show quoted text On 2016/06/08 at 20:47:37, whywhat wrote: > consider using promise_test()? > > should be something like > > promise_test(function(t) > { > return promise_rejects(t, new NotAllowedError(), function() { > // setup video > return video.play(); > }); > }, "test that muted videos don't autoplay when DataSaver is on"); I switched to promise_test.
	16 {

	17 var video = document.createElement('video');

	18 video.src = findMediaFile('video', 'content/test');

	19 video.muted = true;

	20 video.play().then(function() {

	21 assert_notreached("play() should not succeed");

	22 }, t.step_func_done());

	23 });

	24 </script>

	25 </body>

	26 </html>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/autoplay-muted-datasaver-on.html » ('j') | no next file with comments »