Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Issue 2046373002: Fix generation of Xcode project. (Closed)

Created:
4 years, 6 months ago by sdefresne
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix generation of Xcode project. Issue https://codereview.chromium.org/2005483002 changed the code to use FindExtension() instead of base::FilePath::Extension() but did not accomodate for the fact that the extension is now returned without the leading dot. Fix this by changed all the extension values used for comparison to not include the leading dot either. This restore the source indexation when opening the project with Xcode. BUG=297668 Committed: https://crrev.com/63a623cc29066ad0e3c4974851c2e8a56a012f7a Cr-Commit-Position: refs/heads/master@{#398584}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -45 lines) Patch
M tools/gn/xcode_object.cc View 2 chunks +45 lines, -45 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
sdefresne
Please take a look and send to CQ if LGTY.
4 years, 6 months ago (2016-06-08 08:28:41 UTC) #2
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-08 16:03:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046373002/1
4 years, 6 months ago (2016-06-08 16:04:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 16:09:45 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 16:12:50 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63a623cc29066ad0e3c4974851c2e8a56a012f7a
Cr-Commit-Position: refs/heads/master@{#398584}

Powered by Google App Engine
This is Rietveld 408576698