Fix generation of target in Xcode project when using output_name.

Fix generation of target in Xcode project when using output_name.

Target generating an application bundle whose name is different from
the target name needs to set productName and PRODUCT_NAME to the base
name of the application bundle (without .app) and set the name to the
target name otherwise Xcode refuses to launch the application.

BUG=297668
Committed: https://crrev.com/4db57d47a591423e7ecaf1bc965d35f094250e35
Cr-Commit-Position: refs/heads/master@{#395143}

[sdefresne, 2016-05-20 19:19:34]

sdefresne@chromium.org changed reviewers:
+ brettw@chromium.org, dpranke@chromium.org

[sdefresne, 2016-05-20 19:19:35]

Please take a look and send to CQ if LGTY.

Note: I found this issue today when I tried to have a target named "chrome"
generate an application bundle named "Chromium.app". This caused Xcode to print
an error saying that I didn't have the permission to launch the app.

While looking at the project generated by gyp for the same configuration, I
found that the productName and PRODUCT_NAME fields where incorrectly set in the
project generated by gn.

[Dirk Pranke, 2016-05-20 19:35:05]

lgtm

[Dirk Pranke, 2016-05-20 19:35:10]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2016-05-20 19:35:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2005483002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2005483002/1

[commit-bot: I haz the power, 2016-05-20 19:52:51]

Committed patchset #1 (id:1)

[sdefresne, 2016-05-20 19:54:04]

On 2016/05/20 19:52:51, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1)

Thank you for the super quick review!

[commit-bot: I haz the power, 2016-05-20 19:54:48]

Description was changed from

==========
Fix generation of target in Xcode project when using output_name.

Target generating an application bundle whose name is different from
the target name needs to set productName and PRODUCT_NAME to the base
name of the application bundle (without .app) and set the name to the
target name otherwise Xcode refuses to launch the application.

BUG=297668
==========

to

==========
Fix generation of target in Xcode project when using output_name.

Target generating an application bundle whose name is different from
the target name needs to set productName and PRODUCT_NAME to the base
name of the application bundle (without .app) and set the name to the
target name otherwise Xcode refuses to launch the application.

BUG=297668

Committed: https://crrev.com/4db57d47a591423e7ecaf1bc965d35f094250e35
Cr-Commit-Position: refs/heads/master@{#395143}
==========

[commit-bot: I haz the power, 2016-05-20 19:54:49]

Patchset 1 (id:??) landed as
https://crrev.com/4db57d47a591423e7ecaf1bc965d35f094250e35
Cr-Commit-Position: refs/heads/master@{#395143}