media/blink/buffered_data_source.h - Issue 2046253002: When HLS redirects are encountered recreate WebMediaPlayer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/buffered_data_source.h

Issue 2046253002: When HLS redirects are encountered recreate WebMediaPlayer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/base/android/media_codec_util.h ('K') | « media/base/android/media_codec_util.cc ('k') | media/blink/buffered_data_source.cc » ('j') | third_party/WebKit/Source/core/html/HTMLMediaElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/blink/buffered_data_source.h

diff --git a/media/blink/buffered_data_source.h b/media/blink/buffered_data_source.h

index 9ffeb4068c2c3f1d4aff77bf86080a41390ec302..a78edefd5bbbaa7c6a507804ceee6d9d7f463ccf 100644

--- a/media/blink/buffered_data_source.h

+++ b/media/blink/buffered_data_source.h

@@ -114,6 +114,9 @@ class BufferedDataSourceInterface : public DataSource {

// Returns an estimate of the number of bytes held by the data source.

virtual int64_t GetMemoryUsage() const = 0;

+ // Returns the post-Initialize() URL after redirects have been followed.

hubbe 2016/06/15 21:07:56 Please document if it's ok for this to change if a

DaleCurtis 2016/06/15 23:11:30 Done.

+ virtual GURL GetResponseOriginURL() const = 0;

hubbe 2016/06/15 21:07:56 GetResponseOriginalURL only makes sense if you kno

DaleCurtis 2016/06/15 23:11:30 Done.

};

// A data source capable of loading URLs and buffering the data using an

@@ -190,6 +193,8 @@ class MEDIA_BLINK_EXPORT BufferedDataSource

// Returns an estimate of the number of bytes held by the data source.

int64_t GetMemoryUsage() const override;

+ GURL GetResponseOriginURL() const override;

// DataSource implementation.

// Called from demuxer thread.

void Stop() override;