Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 204603003: ElementsAccessor::SetLength() handlified. (Closed)

Created:
6 years, 9 months ago by Igor Sheludko
Modified:
6 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

ElementsAccessor::SetLength() handlified. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20090

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -73 lines) Patch
M src/builtins.cc View 2 chunks +2 lines, -14 lines 0 comments Download
M src/elements.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/elements.cc View 9 chunks +73 lines, -57 lines 0 comments Download
M src/objects.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Igor Sheludko
PTAL
6 years, 9 months ago (2014-03-19 15:29:12 UTC) #1
Yang
lgtm.
6 years, 9 months ago (2014-03-19 16:11:46 UTC) #2
Igor Sheludko
6 years, 9 months ago (2014-03-19 16:29:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20090 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698