Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: src/builtins.cc

Issue 204603003: ElementsAccessor::SetLength() handlified. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/elements.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins.cc
diff --git a/src/builtins.cc b/src/builtins.cc
index a79df97f1e6f4cd212ff87bd1d4be289f59814ea..b48de7f2cd52378eb5e706e1951fba1031192c4f 100644
--- a/src/builtins.cc
+++ b/src/builtins.cc
@@ -548,18 +548,6 @@ static Handle<Object> ElementsAccessorGetWrapper(
}
-// TODO(ishell): Temporary wrapper until handlified.
-static Handle<Object> ElementsAccessorSetLengthWrapper(
- Isolate* isolate,
- ElementsAccessor* accessor,
- Handle<JSArray> array,
- int new_length) {
- CALL_HEAP_FUNCTION(isolate,
- accessor->SetLength(*array, Smi::FromInt(new_length)),
- Object);
-}
-
-
BUILTIN(ArrayPop) {
HandleScope scope(isolate);
Handle<Object> receiver = args.receiver();
@@ -588,8 +576,8 @@ BUILTIN(ArrayPop) {
}
RETURN_IF_EMPTY_HANDLE(isolate, element);
RETURN_IF_EMPTY_HANDLE(isolate,
- ElementsAccessorSetLengthWrapper(
- isolate, accessor, array, new_length));
+ accessor->SetLength(
+ array, handle(Smi::FromInt(new_length), isolate)));
return *element;
}
« no previous file with comments | « no previous file | src/elements.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698