Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1533)

Issue 2045993003: Remove workaround for borked sem_init library function. (Closed)

Created:
4 years, 6 months ago by Michael Starzinger
Modified:
4 years, 6 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove workaround for borked sem_init library function. This workaround had been added because sanitizer interceptors were linking against an old version of GLIBC. The respective sanitizers within LLVM have by now be fixed, workaround can be removed. The original workaround: https://codereview.chromium.org/1407463002 R=machenbach@chromium.org BUG=chromium:536813 Committed: https://crrev.com/c1693f8abcb06e760e4c10f2269a03015725cd84 Cr-Commit-Position: refs/heads/master@{#36816}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M src/base/platform/semaphore.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 6 months ago (2016-06-08 08:39:04 UTC) #1
Michael Achenbach
lgtm thanks!
4 years, 6 months ago (2016-06-08 09:30:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045993003/1
4 years, 6 months ago (2016-06-08 09:32:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 09:34:22 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 09:35:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1693f8abcb06e760e4c10f2269a03015725cd84
Cr-Commit-Position: refs/heads/master@{#36816}

Powered by Google App Engine
This is Rietveld 408576698