Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 1407463002: Workaround for borked sem_init library function. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-js-1
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Workaround for borked sem_init library function. This adds a workaround that zeroes out semaphores before they are initialized. Some versions of sem_init (e.g. GLIBC_2.0) fail to fully zero out the semaphore, leading to {errno == ENOSYS} with subsequent sem_timedwait calls. R=machenbach@chromium.org BUG=chromium:536813 LOG=n Committed: https://crrev.com/263340113713db788e56abda61062dd9513b9f79 Cr-Commit-Position: refs/heads/master@{#31232}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/base/platform/semaphore.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 2 months ago (2015-10-13 09:18:53 UTC) #1
Michael Achenbach
lgtm
5 years, 2 months ago (2015-10-13 09:38:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407463002/20001
5 years, 2 months ago (2015-10-13 09:45:49 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-13 09:53:03 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 09:53:19 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/263340113713db788e56abda61062dd9513b9f79
Cr-Commit-Position: refs/heads/master@{#31232}

Powered by Google App Engine
This is Rietveld 408576698