third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.h - Issue 2045963003: WebScrollbarThemeClientImpl should not be DisplayItemClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.h

Issue 2045963003: WebScrollbarThemeClientImpl should not be DisplayItemClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ScrollbarThemeClient.h ('k') | third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.h

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.h b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.h

index 8090fcb1a544c7a038dd47a4ecb00ff882856608..fb85f3f80f106abac75043e991b997980f4e48b5 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.h

+++ b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.h

@@ -50,7 +50,7 @@ public:

double initialAutoscrollTimerDelay() override;

double autoscrollTimerDelay() override;

- void paintTickmarks(GraphicsContext&, const ScrollbarThemeClient&, const IntRect&) override;

+ void paintTickmarks(GraphicsContext&, const Scrollbar&, const IntRect&) override;

bool shouldRepaintAllPartsOnInvalidation() const override { return false; }

ScrollbarPart invalidateOnThumbPositionChange(

@@ -64,8 +64,8 @@ public:

void setNewPainterForScrollbar(ScrollbarThemeClient&, ScrollbarPainter);

ScrollbarPainter painterForScrollbar(const ScrollbarThemeClient&) const;

- void paintTrackBackground(GraphicsContext&, const ScrollbarThemeClient&, const IntRect&) override;

- void paintThumb(GraphicsContext&, const ScrollbarThemeClient&, const IntRect&) override;

+ void paintTrackBackground(GraphicsContext&, const Scrollbar&, const IntRect&) override;

+ void paintThumb(GraphicsContext&, const Scrollbar&, const IntRect&) override;

float thumbOpacity(const ScrollbarThemeClient&) const override;

@@ -79,7 +79,7 @@ protected:

virtual void updateButtonPlacement(WebScrollbarButtonsPlacement) {}

- void paintGivenTickmarks(SkCanvas*, const ScrollbarThemeClient&, const IntRect&, const Vector<IntRect>&);

+ void paintGivenTickmarks(SkCanvas*, const Scrollbar&, const IntRect&, const Vector<IntRect>&);

IntRect trackRect(const ScrollbarThemeClient&, bool painting = false) override;

IntRect backButtonRect(const ScrollbarThemeClient&, ScrollbarPart, bool painting = false) override;