Remove more FXJSE c-method wrappers.

Remove more FXJSE c-method wrappers.

This Cl cleans up a bunch of the FXJSE_* methods and moves others into the
classes where they most make sense.

Committed: https://pdfium.googlesource.com/pdfium/+/769b137a435fd53a419ebbd1deb8617771b73ef6

[dsinclair, 2016-06-08 14:10:47]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-06-08 14:10:47]

PTAL.

https://codereview.chromium.org/2045883004/diff/1/xfa/fxjse/value.cpp
File xfa/fxjse/value.cpp (right):

https://codereview.chromium.org/2045883004/diff/1/xfa/fxjse/value.cpp#newcode14
xfa/fxjse/value.cpp:14: void FXJSE_ThrowMessage(const CFX_ByteStringC&
utf8Message) {
The utf8Name parameter was always "" so I removed it.

[Tom Sepez, 2016-06-08 17:08:11]

It looks like GetValue() and GetSimpleValue() don't return nullpr, and the other
spots we've just new'd a CFXJSE_Value, so I think my question about static
methods is that it can't happen.

Please doublecheck the reasoning, and make these non-static methods if you
agree.

https://codereview.chromium.org/2045883004/diff/1/xfa/fxfa/parser/xfa_script_...
File xfa/fxfa/parser/xfa_script_imp.cpp (right):

https://codereview.chromium.org/2045883004/diff/1/xfa/fxfa/parser/xfa_script_...
xfa/fxfa/parser/xfa_script_imp.cpp:508: 
Combine object creation into GetGlobalObject as a follow-up?

https://codereview.chromium.org/2045883004/diff/1/xfa/fxjse/cfxjse_arguments.h
File xfa/fxjse/cfxjse_arguments.h (right):

https://codereview.chromium.org/2045883004/diff/1/xfa/fxjse/cfxjse_arguments....
xfa/fxjse/cfxjse_arguments.h:9: 
#include <memory>

https://codereview.chromium.org/2045883004/diff/1/xfa/fxjse/value.cpp
File xfa/fxjse/value.cpp (right):

https://codereview.chromium.org/2045883004/diff/1/xfa/fxjse/value.cpp#newcode14
xfa/fxjse/value.cpp:14: void FXJSE_ThrowMessage(const CFX_ByteStringC&
utf8Message) {
On 2016/06/08 14:10:47, dsinclair wrote:
> The utf8Name parameter was always "" so I removed it.

Acknowledged.

https://codereview.chromium.org/2045883004/diff/1/xfa/fxjse/value.h
File xfa/fxjse/value.h (right):

https://codereview.chromium.org/2045883004/diff/1/xfa/fxjse/value.h#newcode54
xfa/fxjse/value.h:54: static FX_BOOL IsUndefined(CFXJSE_Value* pValue);
why static?  To handle nullptr?  Is the nullptr something that can actually
happen?

Should the argument be const CFXJSE_Value* for these?

[dsinclair, 2016-06-08 19:44:30]

https://codereview.chromium.org/2045883004/diff/1/xfa/fxfa/parser/xfa_script_...
File xfa/fxfa/parser/xfa_script_imp.cpp (right):

https://codereview.chromium.org/2045883004/diff/1/xfa/fxfa/parser/xfa_script_...
xfa/fxfa/parser/xfa_script_imp.cpp:508: 
On 2016/06/08 17:08:10, Tom Sepez wrote:
> Combine object creation into GetGlobalObject as a follow-up?

Acknowledged.

https://codereview.chromium.org/2045883004/diff/1/xfa/fxjse/cfxjse_arguments.h
File xfa/fxjse/cfxjse_arguments.h (right):

https://codereview.chromium.org/2045883004/diff/1/xfa/fxjse/cfxjse_arguments....
xfa/fxjse/cfxjse_arguments.h:9: 
On 2016/06/08 17:08:10, Tom Sepez wrote:
> #include <memory>

Done.

https://codereview.chromium.org/2045883004/diff/1/xfa/fxjse/value.h
File xfa/fxjse/value.h (right):

https://codereview.chromium.org/2045883004/diff/1/xfa/fxjse/value.h#newcode54
xfa/fxjse/value.h:54: static FX_BOOL IsUndefined(CFXJSE_Value* pValue);
On 2016/06/08 17:08:11, Tom Sepez wrote:
> why static?  To handle nullptr?  Is the nullptr something that can actually
> happen?
> 
> Should the argument be const CFXJSE_Value* for these?

Done.

[Tom Sepez, 2016-06-08 20:08:42]

lgtm

[dsinclair, 2016-06-08 20:12:13]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-06-08 20:12:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045883004/20001

[commit-bot: I haz the power, 2016-06-08 20:12:44]

Description was changed from

==========
Remove more FXJSE c-method wrappers.

This Cl cleans up a bunch of the FXJSE_* methods and moves others into the
classes where they most make sense.
==========

to

==========
Remove more FXJSE c-method wrappers.

This Cl cleans up a bunch of the FXJSE_* methods and moves others into the
classes where they most make sense.

Committed:
https://pdfium.googlesource.com/pdfium/+/769b137a435fd53a419ebbd1deb8617771b7...
==========

[commit-bot: I haz the power, 2016-06-08 20:12:44]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/769b137a435fd53a419ebbd1deb8617771b7...