skia/public/interfaces/bitmap_skbitmap_struct_traits.cc - Issue 2045723002: mojo ArrayTraits<T>::Resize returns bool indicating success

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: skia/public/interfaces/bitmap_skbitmap_struct_traits.cc

Issue 2045723002: mojo ArrayTraits<T>::Resize returns bool indicating success (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/cpp/bindings/array_traits.h ('K') | « skia/public/interfaces/bitmap_skbitmap_struct_traits.h ('k') | ui/events/mojo/latency_info_struct_traits.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: skia/public/interfaces/bitmap_skbitmap_struct_traits.cc

diff --git a/skia/public/interfaces/bitmap_skbitmap_struct_traits.cc b/skia/public/interfaces/bitmap_skbitmap_struct_traits.cc

index 7d19bb6715d2cac0d268ae8e3139f16727659060..904a8436c92573023e5366f2c07e732543dba947 100644

--- a/skia/public/interfaces/bitmap_skbitmap_struct_traits.cc

+++ b/skia/public/interfaces/bitmap_skbitmap_struct_traits.cc

@@ -138,8 +138,8 @@ const uint8_t& ArrayTraits<BitmapBuffer>::GetAt(const BitmapBuffer& b,

}

// static

-void ArrayTraits<BitmapBuffer>::Resize(BitmapBuffer& b, size_t size) {

- CHECK_EQ(size, b.size);

+bool ArrayTraits<BitmapBuffer>::Resize(BitmapBuffer& b, size_t size) {

+ return b.size == size;

}

// static