mojo/public/cpp/bindings/array_traits.h - Issue 2045723002: mojo ArrayTraits<T>::Resize returns bool indicating success

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/array_traits.h

Issue 2045723002: mojo ArrayTraits<T>::Resize returns bool indicating success (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/public/cpp/bindings/array_traits.h

diff --git a/mojo/public/cpp/bindings/array_traits.h b/mojo/public/cpp/bindings/array_traits.h

index f94648bdaa27ca07a5a75f8389a202c9cc2ba671..f7e22125adc9d1e8c034bede7026c05765c88492 100644

--- a/mojo/public/cpp/bindings/array_traits.h

+++ b/mojo/public/cpp/bindings/array_traits.h

@@ -32,7 +32,7 @@ namespace mojo {

// static T& GetAt(CustomArray<T>& input, size_t index);

// static const T& GetAt(const CustomArray<T>& input, size_t index);

-// static void Resize(CustomArray<T>& input, size_t size);

+// static bool Resize(CustomArray<T>& input, size_t size);

yzshen1 2016/06/06 21:00:06 Please consider adding comment: Returning false re

Fady Samuel 2016/06/06 22:52:09 Done.

// };

template <typename T>

« no previous file with comments | « gpu/ipc/common/mailbox_struct_traits.cc ('k') | mojo/public/cpp/bindings/array_traits_standard.h » ('j') | no next file with comments »