Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2045713002: [Merge to 2743] Exit immediately on failure to allocate SharedMemory. (Closed)

Created:
4 years, 6 months ago by erikchen
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[Merge to 2743] Exit immediately on failure to allocate SharedMemory. Callers of ChildSharedBitmapManager::AllocateSharedMemoryBitmap are not prepared to handle failures. The existence of the FastShutdown path means that any message might fail. Either all callers of ChildSharedBitmapManager::AllocateSharedMemoryBitmap need to handle failure, or else the process needs to exit immediately. The latter seems more manageable. BUG=615121 Review-Url: https://codereview.chromium.org/2028833003 Cr-Commit-Position: refs/heads/master@{#397496} (cherry picked from commit 7eb3f7fe5233455626980c3517f7fa189e6c9675) Committed: https://chromium.googlesource.com/chromium/src/+/9ac167cc11c50985776c4281a77c33f66f4cf97e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M content/child/child_shared_bitmap_manager.cc View 2 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
erikchen
4 years, 6 months ago (2016-06-06 21:01:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9ac167cc11c50985776c4281a77c33f66f4cf97e.

Powered by Google App Engine
This is Rietveld 408576698