Exit immediately on failure to allocate SharedMemory.

Exit immediately on failure to allocate SharedMemory.

Callers of ChildSharedBitmapManager::AllocateSharedMemoryBitmap are not prepared
to handle failures. The existence of the FastShutdown path means that any
message might fail. Either all callers of
ChildSharedBitmapManager::AllocateSharedMemoryBitmap need to handle failure, or
else the process needs to exit immediately. The latter seems more manageable.

BUG=615121
Committed: https://crrev.com/7eb3f7fe5233455626980c3517f7fa189e6c9675
Cr-Commit-Position: refs/heads/master@{#397496}

[erikchen, 2016-05-31 21:02:09]

Description was changed from

==========
Exit immediately on failure to allocate SharedMemory.

BUG=
==========

to

==========
Exit immediately on failure to allocate SharedMemory.

Callers of ChildSharedBitmapManager::AllocateSharedMemoryBitmap are not prepared
to handle failures during shutdown. As a short term solution, exit immediately
rather than returning a nullptr. The only point of this CL is to suppress an
otherwise innocuous crash during Renderer shutdown.

BUG=615121
==========

[erikchen, 2016-05-31 21:07:46]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-31 21:08:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028833003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2028833003/1

[erikchen, 2016-05-31 21:08:47]

erikchen@chromium.org changed reviewers:
+ danakj@chromium.org

[erikchen, 2016-05-31 21:08:48]

danakj: Please review.

[commit-bot: I haz the power, 2016-05-31 21:54:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-31 21:54:33]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[erikchen, 2016-05-31 22:11:29]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-31 22:12:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028833003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2028833003/20001

[commit-bot: I haz the power, 2016-05-31 23:47:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-31 23:47:56]

Dry run: This issue passed the CQ dry run.

[erikchen, 2016-06-01 17:00:44]

erikchen@chromium.org changed reviewers:
+ piman@chromium.org

[erikchen, 2016-06-01 17:00:44]

piman: Please review.

We can suppress the crashes if you want with this CL - I don't think it's a good
long term solution.

[erikchen, 2016-06-01 19:49:26]

Description was changed from

==========
Exit immediately on failure to allocate SharedMemory.

Callers of ChildSharedBitmapManager::AllocateSharedMemoryBitmap are not prepared
to handle failures during shutdown. As a short term solution, exit immediately
rather than returning a nullptr. The only point of this CL is to suppress an
otherwise innocuous crash during Renderer shutdown.

BUG=615121
==========

to

==========
Exit immediately on failure to allocate SharedMemory.

Callers of ChildSharedBitmapManager::AllocateSharedMemoryBitmap are not prepared
to handle failures. The FastShutdown path means that any messages might be
queued when the channel is destroyed, so either all callers of
ChildSharedBitmapManager::AllocateSharedMemoryBitmap need to handle failure, or
else the process needs to exit immediately. The latter seems more manageable.

BUG=615121
==========

[erikchen, 2016-06-01 19:51:41]

Description was changed from

==========
Exit immediately on failure to allocate SharedMemory.

Callers of ChildSharedBitmapManager::AllocateSharedMemoryBitmap are not prepared
to handle failures. The FastShutdown path means that any messages might be
queued when the channel is destroyed, so either all callers of
ChildSharedBitmapManager::AllocateSharedMemoryBitmap need to handle failure, or
else the process needs to exit immediately. The latter seems more manageable.

BUG=615121
==========

to

==========
Exit immediately on failure to allocate SharedMemory.

Callers of ChildSharedBitmapManager::AllocateSharedMemoryBitmap are not prepared
to handle failures. The existence of the FastShutdown path means that any
message might fail. Either all callers of
ChildSharedBitmapManager::AllocateSharedMemoryBitmap need to handle failure, or
else the process needs to exit immediately. The latter seems more manageable.

BUG=615121
==========

[erikchen, 2016-06-01 19:53:46]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[erikchen, 2016-06-01 19:54:06]

On 2016/06/01 17:00:44, erikchen wrote:
> piman: Please review.
> 
> We can suppress the crashes if you want with this CL - I don't think it's a
good
> long term solution.

piman: Please review.

Because of the existence of the FastShutdown path for Renderers, I now think
this is a reasonable solution.

[commit-bot: I haz the power, 2016-06-01 19:54:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028833003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2028833003/40001

[erikchen, 2016-06-01 21:03:09]

erikchen@chromium.org changed reviewers:
+ avi@chromium.org

[erikchen, 2016-06-01 21:03:10]

+avi

I think piman@ is at an offsite today. anantha@ wants a fix in by 5pm PST today.

[Avi (use Gerrit), 2016-06-01 21:07:38]

I really don't like EXIT_SUCCESS.

https://codereview.chromium.org/2028833003/diff/40001/content/child/child_sha...
File content/child/child_shared_bitmap_manager.cc (right):

https://codereview.chromium.org/2028833003/diff/40001/content/child/child_sha...
content/child/child_shared_bitmap_manager.cc:117: exit(EXIT_SUCCESS);
/base/process/memory.h's TerminateBecauseOutOfMemory() ?

[erikchen, 2016-06-01 21:10:47]

https://codereview.chromium.org/2028833003/diff/40001/content/child/child_sha...
File content/child/child_shared_bitmap_manager.cc (right):

https://codereview.chromium.org/2028833003/diff/40001/content/child/child_sha...
content/child/child_shared_bitmap_manager.cc:117: exit(EXIT_SUCCESS);
On 2016/06/01 21:07:38, Avi wrote:
> /base/process/memory.h's TerminateBecauseOutOfMemory() ?

That is both inaccurate, as this is not an OOM, and emits a CrashDump, which
distorts our crash figures and causes ReleaseBlock bugs to be assigned to me.

[commit-bot: I haz the power, 2016-06-01 21:23:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 21:23:22]

Dry run: This issue passed the CQ dry run.

[erikchen, 2016-06-02 16:42:57]

On 2016/06/01 21:23:22, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

avi: Ping?

[Avi (use Gerrit), 2016-06-02 18:05:13]

Can we at least comment why it's EXIT_SUCCESS rather than some other value?

LGTM

[erikchen, 2016-06-02 18:17:16]

On 2016/06/02 18:05:13, Avi wrote:
> Can we at least comment why it's EXIT_SUCCESS rather than some other value?
Done.

> 
> LGTM

[erikchen, 2016-06-02 18:17:24]

On 2016/06/02 18:05:13, Avi wrote:
> Can we at least comment why it's EXIT_SUCCESS rather than some other value?
Done.

> 
> LGTM

[erikchen, 2016-06-02 18:17:32]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-06-02 18:17:32]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2028833003/#ps60001
(title: "Comments from avi.")

[commit-bot: I haz the power, 2016-06-02 18:18:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028833003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2028833003/60001

[commit-bot: I haz the power, 2016-06-02 20:13:41]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-02 20:16:03]

Description was changed from

==========
Exit immediately on failure to allocate SharedMemory.

Callers of ChildSharedBitmapManager::AllocateSharedMemoryBitmap are not prepared
to handle failures. The existence of the FastShutdown path means that any
message might fail. Either all callers of
ChildSharedBitmapManager::AllocateSharedMemoryBitmap need to handle failure, or
else the process needs to exit immediately. The latter seems more manageable.

BUG=615121
==========

to

==========
Exit immediately on failure to allocate SharedMemory.

Callers of ChildSharedBitmapManager::AllocateSharedMemoryBitmap are not prepared
to handle failures. The existence of the FastShutdown path means that any
message might fail. Either all callers of
ChildSharedBitmapManager::AllocateSharedMemoryBitmap need to handle failure, or
else the process needs to exit immediately. The latter seems more manageable.

BUG=615121

Committed: https://crrev.com/7eb3f7fe5233455626980c3517f7fa189e6c9675
Cr-Commit-Position: refs/heads/master@{#397496}
==========

[commit-bot: I haz the power, 2016-06-02 20:16:05]

Patchset 4 (id:??) landed as
https://crrev.com/7eb3f7fe5233455626980c3517f7fa189e6c9675
Cr-Commit-Position: refs/heads/master@{#397496}

[piman, 2016-06-02 23:25:58]

belated lgtm.