mac: Remove GPU bug workarounds for OS X versions before 10.9

mac: Remove GPU bug workarounds for OS X versions before 10.9

BUG=579255
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/18e33edffbd09b32095803d8937b15339d73e4ab
Cr-Commit-Position: refs/heads/master@{#398427}

[Nico, 2016-06-06 19:34:19]

Description was changed from

==========
mac: Remove GPU bug workarounds for OS X versions before 10.9

BUG=579255
==========

to

==========
mac: Remove GPU bug workarounds for OS X versions before 10.9

BUG=579255
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Nico, 2016-06-06 19:37:23]

thakis@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-06-06 23:56:38]

kbr@chromium.org changed reviewers:
+ zmo@chromium.org

[Ken Russell (switch to Gerrit), 2016-06-06 23:56:39]

LGTM, and thanks for the cleanups, but I'm not an OWNER in gpu/command_buffer.
CC'ing zmo.

https://codereview.chromium.org/2045663002/diff/60001/gpu/config/gpu_driver_b...
File gpu/config/gpu_driver_bug_workaround_type.h (left):

https://codereview.chromium.org/2045663002/diff/60001/gpu/config/gpu_driver_b...
gpu/config/gpu_driver_bug_workaround_type.h:154:
GPU_OP(UNROLL_FOR_LOOP_WITH_SAMPLER_ARRAY_INDEX,           \
We should file a bug against ANGLE to remove the associated code there, if it's
no longer referenced.

[Zhenyao Mo, 2016-06-07 00:23:19]

lgtm
thanks for cleaning this up

[Zhenyao Mo, 2016-06-07 00:26:06]

https://codereview.chromium.org/2045663002/diff/60001/gpu/config/gpu_driver_b...
File gpu/config/gpu_driver_bug_workaround_type.h (left):

https://codereview.chromium.org/2045663002/diff/60001/gpu/config/gpu_driver_b...
gpu/config/gpu_driver_bug_workaround_type.h:154:
GPU_OP(UNROLL_FOR_LOOP_WITH_SAMPLER_ARRAY_INDEX,           \
On 2016/06/06 23:56:39, Ken Russell wrote:
> We should file a bug against ANGLE to remove the associated code there, if
it's
> no longer referenced.

Filed: https://bugs.chromium.org/p/angleproject/issues/detail?id=1404

[Nico, 2016-06-07 01:07:43]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-06-07 01:08:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045663002/60001

[commit-bot: I haz the power, 2016-06-07 01:34:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 01:34:26]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Zhenyao Mo, 2016-06-07 02:12:59]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2016-06-07 02:13:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045663002/60001

[commit-bot: I haz the power, 2016-06-07 02:22:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 02:22:23]

Try jobs failed on following builders:
  linux_optional_gpu_tests_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)

[Nico, 2016-06-07 18:30:30]

The CQ bit was checked by thakis@chromium.org

[Nico, 2016-06-07 18:30:31]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2045663002/#ps80001
(title: "json")

[commit-bot: I haz the power, 2016-06-07 18:30:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045663002/80001

[commit-bot: I haz the power, 2016-06-07 21:25:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 21:25:36]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ken Russell (switch to Gerrit), 2016-06-07 21:35:31]

On 2016/06/07 21:25:36, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Sorry about that. Please feel free to add the line:

    # There are currently no blacklist entries disabling all GPU
    # functionality on Mac OS.
    self.Fail('GpuProcess.no_gpu_process', ['mac'], bug=579255)

to src/content/test/gpu/gpu_tests/gpu_process_expectations.py. Not necessary to
get a review from me.

[Nico, 2016-06-07 21:50:28]

The CQ bit was checked by thakis@chromium.org

[Nico, 2016-06-07 21:50:28]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2045663002/#ps100001
(title: "kbr comment")

[commit-bot: I haz the power, 2016-06-07 21:51:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045663002/100001

[commit-bot: I haz the power, 2016-06-08 00:10:06]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-08 00:13:10]

Description was changed from

==========
mac: Remove GPU bug workarounds for OS X versions before 10.9

BUG=579255
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
mac: Remove GPU bug workarounds for OS X versions before 10.9

BUG=579255
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/18e33edffbd09b32095803d8937b15339d73e4ab
Cr-Commit-Position: refs/heads/master@{#398427}
==========

[commit-bot: I haz the power, 2016-06-08 00:13:11]

Patchset 6 (id:??) landed as
https://crrev.com/18e33edffbd09b32095803d8937b15339d73e4ab
Cr-Commit-Position: refs/heads/master@{#398427}