third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp - Issue 2045603002: Handle the "key" field as opposed to keyIdentifier field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp

Issue 2045603002: Handle the "key" field as opposed to keyIdentifier field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove initialization of the view Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp ('k') | third_party/WebKit/Source/core/input/KeyboardEventManager.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp b/third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp

index 12586db3b5b07cecc9fde70d469ed6360d9a31dd..49ed736f024506fd35942f71f60b3c02fc764116 100644

--- a/third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp

@@ -95,9 +95,9 @@ void DateTimeFieldElement::defaultKeyboardEventHandler(KeyboardEvent* keyboardEv

if (isDisabled() || isFieldOwnerDisabled())

return;

- const String& keyIdentifier = keyboardEvent->keyIdentifier();

+ const String& key = keyboardEvent->key();

- if (keyIdentifier == "Left") {

+ if (key == "ArrowLeft") {

if (!m_fieldOwner)

return;

// FIXME: We'd like to use FocusController::advanceFocus(FocusDirectionLeft, ...)

@@ -107,7 +107,7 @@ void DateTimeFieldElement::defaultKeyboardEventHandler(KeyboardEvent* keyboardEv

return;

}

- if (keyIdentifier == "Right") {

+ if (key == "ArrowRight") {

if (!m_fieldOwner)

return;

// FIXME: We'd like to use FocusController::advanceFocus(FocusDirectionRight, ...)

@@ -120,7 +120,7 @@ void DateTimeFieldElement::defaultKeyboardEventHandler(KeyboardEvent* keyboardEv

if (isFieldOwnerReadOnly())

return;

- if (keyIdentifier == "Down") {

+ if (key == "ArrowDown") {

if (keyboardEvent->getModifierState("Alt"))

return;

keyboardEvent->setDefaultHandled();

@@ -128,13 +128,13 @@ void DateTimeFieldElement::defaultKeyboardEventHandler(KeyboardEvent* keyboardEv

return;

}

- if (keyIdentifier == "Up") {

+ if (key == "ArrowUp") {

keyboardEvent->setDefaultHandled();

stepUp();

return;

}

- if (keyIdentifier == "U+0008" || keyIdentifier == "U+007F") {

+ if (key == "Backspace" || key == "Delete") {

keyboardEvent->setDefaultHandled();

setEmptyValue(DispatchEvent);

return;