third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp - Issue 2045603002: Handle the "key" field as opposed to keyIdentifier field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp

Issue 2045603002: Handle the "key" field as opposed to keyIdentifier field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove initialization of the view Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/forms/SearchInputType.cpp ('k') | third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp b/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp

index ee6539e924919aa4c9de6c53962dc843355ed8a1..cb8ebf0b6362e30e4015099ed45a23b925755ae1 100644

--- a/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp

@@ -210,10 +210,10 @@ void TextFieldInputType::handleKeydownEventForSpinButton(KeyboardEvent* event)

{

if (element().isDisabledOrReadOnly())

return;

- const String& key = event->keyIdentifier();

- if (key == "Up")

+ const String& key = event->key();

+ if (key == "ArrowUp")

spinButtonStepUp();

- else if (key == "Down" && !event->altKey())

+ else if (key == "ArrowDown" && !event->altKey())

spinButtonStepDown();

else

return;