[Third Party] Add Bouncycastle to Chromium.

[Third Party] Add Bouncycastle to Chromium.

This jar is a dependency for Robolectric 3.0.

BUG=522043
Committed: https://crrev.com/378c735d525c1ff8ba109c7583edcf4fdd4c305c
Cr-Commit-Position: refs/heads/master@{#403343}

[mikecase (-- gone --), 2016-06-07 23:33:46]

mikecase@chromium.org changed reviewers:
+ jbudorick@chromium.org, yolandyan@chromium.org

[mikecase (-- gone --), 2016-06-22 21:22:16]

mikecase@chromium.org changed reviewers:
+ klobag@chromium.org

[mikecase (-- gone --), 2016-06-22 21:22:16]

+klobag for third_party/ review

Got open-source approval via email.
Tested running "gclient runhooks" locally.

This is a dependency for Robolectric 3.0

[the real yoland, 2016-06-22 21:45:35]

lgtm

[the real yoland, 2016-06-22 21:49:53]

lgtm

[jbudorick, 2016-06-27 13:18:52]

https://codereview.chromium.org/2045583006/diff/40001/third_party/bouncycastl...
File third_party/bouncycastle/LICENSE (right):

https://codereview.chromium.org/2045583006/diff/40001/third_party/bouncycastl...
third_party/bouncycastle/LICENSE:1: Copyright (c) 2000 - 2015 The Legion of the
Bouncy Castle Inc. (http://www.bouncycastle.org)
:)

https://codereview.chromium.org/2045583006/diff/40001/third_party/bouncycastl...
File third_party/bouncycastle/README.chromium (right):

https://codereview.chromium.org/2045583006/diff/40001/third_party/bouncycastl...
third_party/bouncycastle/README.chromium:7: Description: Bouncy castle provides
a set of Java lightweight cryptography APIs.
Can you mention that this is testonly in here? As-is, having "Security Critical:
no" + "cryptography APIs" sounds very strange.

[mikecase (-- gone --), 2016-06-27 18:13:47]

https://codereview.chromium.org/2045583006/diff/40001/third_party/bouncycastl...
File third_party/bouncycastle/README.chromium (right):

https://codereview.chromium.org/2045583006/diff/40001/third_party/bouncycastl...
third_party/bouncycastle/README.chromium:7: Description: Bouncy castle provides
a set of Java lightweight cryptography APIs.
On 2016/06/27 at 13:18:52, jbudorick (EMEA til June 30) wrote:
> Can you mention that this is testonly in here? As-is, having "Security
Critical: no" + "cryptography APIs" sounds very strange.

Done. Added "This library is used by tests only."

[klobag.chromium, 2016-06-29 18:29:35]

lgtm

[jbudorick, 2016-06-30 08:18:54]

lgtm

[mikecase (-- gone --), 2016-06-30 22:44:07]

The CQ bit was checked by mikecase@chromium.org

[mikecase (-- gone --), 2016-06-30 22:44:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
yolandyan@chromium.org
Link to the patchset: https://codereview.chromium.org/2045583006/#ps60001
(title: "Added note about Bouncy Castle being test only.")

[commit-bot: I haz the power, 2016-06-30 22:44:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 23:40:12]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-30 23:42:26]

Description was changed from

==========
[Third Party] Add Bouncycastle to Chromium.

This jar is a dependency for Robolectric 3.0.

BUG=522043
==========

to

==========
[Third Party] Add Bouncycastle to Chromium.

This jar is a dependency for Robolectric 3.0.

BUG=522043

Committed: https://crrev.com/378c735d525c1ff8ba109c7583edcf4fdd4c305c
Cr-Commit-Position: refs/heads/master@{#403343}
==========

[commit-bot: I haz the power, 2016-06-30 23:42:27]

Patchset 4 (id:??) landed as
https://crrev.com/378c735d525c1ff8ba109c7583edcf4fdd4c305c
Cr-Commit-Position: refs/heads/master@{#403343}