third_party/bouncycastle/README.chromium - Issue 2045583006: [Third Party] Add Bouncycastle to Chromium.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/bouncycastle/README.chromium

Issue 2045583006: [Third Party] Add Bouncycastle to Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated DEPS file. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 Name: Bouncy Castle

	2 URL: https://www.bouncycastle.org/java.html

	3 Version: 1.46

	4 License: MIT

	5 License File: NOT_SHIPPED

	6 Security Critical: no

	7 Description: Bouncy castle provides a set of Java lightweight cryptography APIs.
	jbudorick 2016/06/27 13:18:52 Can you mention that this is testonly in here? As- Can you mention that this is testonly in here? As-is, having "Security Critical: no" + "cryptography APIs" sounds very strange. mikecase (-- gone --) 2016/06/27 18:13:47 Done. Added "This library is used by tests only." Show quoted text On 2016/06/27 at 13:18:52, jbudorick (EMEA til June 30) wrote: > Can you mention that this is testonly in here? As-is, having "Security Critical: no" + "cryptography APIs" sounds very strange. Done. Added "This library is used by tests only."
	8 Local Modifications: None

OLD	NEW