Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2045493002: build: add path_config=kitchen to infra recipes tests (Closed)

Created:
4 years, 6 months ago by Paweł Hajdan Jr.
Modified:
4 years, 6 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

build: add path_config=kitchen to infra recipes tests This is a preparation before moving them to remote_run. See https://groups.google.com/a/chromium.org/d/msg/infra-dev/pt70Gth16KM/y38lfEibBAAJ for additional context. Depends on https://codereview.chromium.org/2045473002 BUG=617565 Committed: https://chromium.googlesource.com/chromium/tools/build/+/6a58c12bc9708904f28b0ff6f2d0081c4b443b1e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -11 lines) Patch
M scripts/slave/recipes/infra/build_conda_cipd_pkg.py View 1 chunk +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/infra/depot_tools_builder.py View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/infra/infra_continuous.py View 7 chunks +7 lines, -1 line 0 comments Download
M scripts/slave/recipes/infra/infra_continuous.expected/infra-64.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/infra/luci_gae.py View 4 chunks +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/infra/luci_gae.expected/presubmit_try_job.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/infra/luci_go.py View 4 chunks +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/infra/luci_go.expected/presubmit_try_job.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/infra/recipes_py_continuous.py View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Paweł Hajdan Jr.
4 years, 6 months ago (2016-06-06 11:02:30 UTC) #2
tandrii(chromium)
LGTM but i'd be nice if we can avoid typing api.properties(path_config='kitchen') every time.
4 years, 6 months ago (2016-06-06 12:03:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045493002/1
4 years, 6 months ago (2016-06-06 12:26:49 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 12:30:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/6a58c12bc9708904f28b...

Powered by Google App Engine
This is Rietveld 408576698