Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issue 2045473002: depot_tools: expose paths to presubmit_support.py and upload_to_google_storage.py (Closed)

Created:
4 years, 6 months ago by Paweł Hajdan Jr.
Modified:
4 years, 6 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

depot_tools: expose paths to presubmit_support.py and upload_to_google_storage.py They're needed by infra recipes (https://codereview.chromium.org/2045493002). BUG=617565 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300695

Patch Set 1 #

Patch Set 2 : presubmit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M recipe_modules/depot_tools/api.py View 1 chunk +4 lines, -0 lines 0 comments Download
M recipe_modules/depot_tools/example.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M recipe_modules/depot_tools/example.expected/basic.json View 1 1 chunk +7 lines, -0 lines 0 comments Download
M recipe_modules/depot_tools/example.expected/win.json View 1 1 chunk +7 lines, -0 lines 0 comments Download
M recipe_modules/presubmit/api.py View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045473002/1
4 years, 6 months ago (2016-06-06 11:01:25 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Depot Tools Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubmit/builds/549)
4 years, 6 months ago (2016-06-06 11:07:36 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045473002/10001
4 years, 6 months ago (2016-06-06 11:14:35 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-06 11:18:06 UTC) #9
Paweł Hajdan Jr.
4 years, 6 months ago (2016-06-06 11:24:39 UTC) #11
tandrii(chromium)
lgtm
4 years, 6 months ago (2016-06-06 12:05:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045473002/10001
4 years, 6 months ago (2016-06-06 12:10:35 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 12:13:32 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:10001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300695

Powered by Google App Engine
This is Rietveld 408576698