Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2045263003: Stop trying to build files that are not there (Closed)

Created:
4 years, 6 months ago by scroggo_chromium
Modified:
4 years, 6 months ago
Reviewers:
msarett, scroggo, dogben, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Stop trying to build files that are not there The bzl version of Skia does not have these files. Don't try to build them. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2045263003 Committed: https://skia.googlesource.com/skia/+/faa9036ff160b0c738168f03a6ec03982ad36257

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M public.bzl View 2 chunks +0 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
scroggo
For staging, I think it makes sense to stop building these files, then copy them ...
4 years, 6 months ago (2016-06-08 20:52:55 UTC) #3
msarett
lgtm
4 years, 6 months ago (2016-06-08 20:53:58 UTC) #4
mtklein
lgtm ok
4 years, 6 months ago (2016-06-08 20:54:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045263003/1
4 years, 6 months ago (2016-06-08 20:57:28 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 21:32:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/faa9036ff160b0c738168f03a6ec03982ad36257

Powered by Google App Engine
This is Rietveld 408576698