Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2044703006:
Bring back compiling third_party/libpng in public.bzl (Closed)
DescriptionBring back compiling third_party/libpng in public.bzl
Disable the optimizations for simplicity, as suggested in [1].
Remove PNG_SKIP_SETJMP_CHECK, which is not defined in version 1.6.22.
[1] https://codereview.chromium.org/2033063003/diff/20001/public.bzl#newcode84
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2044703006
Committed: https://skia.googlesource.com/skia/+/e6939c15dc0c09f1348988dc56e50b6bea27b7ce
Patch Set 1 #Patch Set 2 : Rebase on top of removing libpng, and bring it back #
Total comments: 5
Patch Set 3 : Don't mess with iOS #
Depends on Patchset: Messages
Total messages: 18 (8 generated)
Description was changed from ========== Add defines for building Skia's png in public.bzl Disable the optimizations, for simplicity, as suggested in [1]. [1] https://codereview.chromium.org/2033063003/diff/20001/public.bzl#newcode84 ========== to ========== Add defines for building Skia's png in public.bzl Disable the optimizations, for simplicity, as suggested in [1]. [1] https://codereview.chromium.org/2033063003/diff/20001/public.bzl#newcode84 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2044703006 ==========
Description was changed from ========== Add defines for building Skia's png in public.bzl Disable the optimizations, for simplicity, as suggested in [1]. [1] https://codereview.chromium.org/2033063003/diff/20001/public.bzl#newcode84 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2044703006 ========== to ========== Add defines for building Skia's png in public.bzl Disable the optimizations, for simplicity, as suggested in [1]. Remove PNG_SKIP_SETJMP_CHECK, which is not defined in version 1.6.22. [1] https://codereview.chromium.org/2033063003/diff/20001/public.bzl#newcode84 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2044703006 ==========
scroggo@google.com changed reviewers: + benjaminwagner@google.com, msarett@google.com, mtklein@google.com
lgtm
Description was changed from ========== Add defines for building Skia's png in public.bzl Disable the optimizations, for simplicity, as suggested in [1]. Remove PNG_SKIP_SETJMP_CHECK, which is not defined in version 1.6.22. [1] https://codereview.chromium.org/2033063003/diff/20001/public.bzl#newcode84 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2044703006 ========== to ========== Bring back compiling third_party/libpng in public.bzl Disable the optimizations for simplicity, as suggested in [1]. Remove PNG_SKIP_SETJMP_CHECK, which is not defined in version 1.6.22. [1] https://codereview.chromium.org/2033063003/diff/20001/public.bzl#newcode84 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2044703006 ==========
lgtm
https://codereview.chromium.org/2044703006/diff/20001/public.bzl File public.bzl (right): https://codereview.chromium.org/2044703006/diff/20001/public.bzl#newcode83 public.bzl:83: "third_party/libpng/*.c", These files are not synced to Google3. I will reply via email on the changes you would need to make.
https://codereview.chromium.org/2044703006/diff/20001/public.bzl File public.bzl (right): https://codereview.chromium.org/2044703006/diff/20001/public.bzl#newcode83 public.bzl:83: "third_party/libpng/*.c", On 2016/06/09 at 12:27:18, Ben Wagner wrote: > These files are not synced to Google3. I will reply via email on the changes you would need to make. I responded in internal cl/124383007.
https://codereview.chromium.org/2044703006/diff/20001/public.bzl File public.bzl (right): https://codereview.chromium.org/2044703006/diff/20001/public.bzl#newcode584 public.bzl:584: # Build our version of libpng I don't know if these defines will work for the iOS build. You might want to coordinate with luizp to make sure things will still work after this change.
https://codereview.chromium.org/2044703006/diff/20001/public.bzl File public.bzl (right): https://codereview.chromium.org/2044703006/diff/20001/public.bzl#newcode83 public.bzl:83: "third_party/libpng/*.c", On 2016/06/09 12:35:20, Ben Wagner wrote: > On 2016/06/09 at 12:27:18, Ben Wagner wrote: > > These files are not synced to Google3. I will reply via email on the changes > you would need to make. > > I responded in internal cl/124383007. I think that is resolved by that CL and cl/125465882. https://codereview.chromium.org/2044703006/diff/20001/public.bzl#newcode584 public.bzl:584: # Build our version of libpng On 2016/06/09 12:38:02, Ben Wagner wrote: > I don't know if these defines will work for the iOS build. You might want to > coordinate with luizp to make sure things will still work after this change. I'll leave PNG out of iOS for now, so it will be the same as before.
The CQ bit was checked by scroggo@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from msarett@google.com, mtklein@google.com Link to the patchset: https://codereview.chromium.org/2044703006/#ps40001 (title: "Don't mess with iOS")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044703006/40001
Message was sent while issue was closed.
Description was changed from ========== Bring back compiling third_party/libpng in public.bzl Disable the optimizations for simplicity, as suggested in [1]. Remove PNG_SKIP_SETJMP_CHECK, which is not defined in version 1.6.22. [1] https://codereview.chromium.org/2033063003/diff/20001/public.bzl#newcode84 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2044703006 ========== to ========== Bring back compiling third_party/libpng in public.bzl Disable the optimizations for simplicity, as suggested in [1]. Remove PNG_SKIP_SETJMP_CHECK, which is not defined in version 1.6.22. [1] https://codereview.chromium.org/2033063003/diff/20001/public.bzl#newcode84 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2044703006 Committed: https://skia.googlesource.com/skia/+/e6939c15dc0c09f1348988dc56e50b6bea27b7ce ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/e6939c15dc0c09f1348988dc56e50b6bea27b7ce
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2090643002/ by scroggo@google.com. The reason for reverting is: Breaking Google3.
Message was sent while issue was closed.
Description was changed from ========== Bring back compiling third_party/libpng in public.bzl Disable the optimizations for simplicity, as suggested in [1]. Remove PNG_SKIP_SETJMP_CHECK, which is not defined in version 1.6.22. [1] https://codereview.chromium.org/2033063003/diff/20001/public.bzl#newcode84 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2044703006 Committed: https://skia.googlesource.com/skia/+/e6939c15dc0c09f1348988dc56e50b6bea27b7ce ========== to ========== Bring back compiling third_party/libpng in public.bzl Disable the optimizations for simplicity, as suggested in [1]. Remove PNG_SKIP_SETJMP_CHECK, which is not defined in version 1.6.22. [1] https://codereview.chromium.org/2033063003/diff/20001/public.bzl#newcode84 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2044703006 Committed: https://skia.googlesource.com/skia/+/e6939c15dc0c09f1348988dc56e50b6bea27b7ce ========== |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
