Compute and cache element NativeBehavior during resolution.

Compute and cache element NativeBehavior during resolution.

NativeBehavior for method calls and field load/store are now computed
during resolution and apply as part of the world impact. This prepares
for (full) serialization/deserialization of native elements.

R=het@google.com

Committed: https://github.com/dart-lang/sdk/commit/286b21133b8f64467fbce6b92e67ff4b3f28d782

[Johnni Winther, 2016-06-08 13:49:10]

johnniwinther@google.com changed reviewers:
+ het@google.com

[Harry Terkelsen, 2016-06-08 16:34:42]

lgtm

https://codereview.chromium.org/2045223002/diff/20001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/common/backend_api.dart (right):

https://codereview.chromium.org/2045223002/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/backend_api.dart:410: void registerNativeData(var
nativeData);
I think this should be 'NativeBehavior nativeData'

https://codereview.chromium.org/2045223002/diff/20001/pkg/compiler/lib/src/na...
File pkg/compiler/lib/src/native/enqueue.dart (right):

https://codereview.chromium.org/2045223002/diff/20001/pkg/compiler/lib/src/na...
pkg/compiler/lib/src/native/enqueue.dart:38: // [handleMethodAnnotations] to
[JavaScriptBackend] or [NativeData].
do these do anything if the element is not native? I see that it is called
before checking if it is actually native. If it does nothing for non-native
elements then it can just be executed when you register the native element.

[Johnni Winther, 2016-06-09 07:50:57]

Description was changed from

==========
Compute and cache element NativeBehavior during resolution.

NativeBehavior for method calls and field load/store are now computed
during resolution and apply as part of the world impact. This prepares
for (full) serialization/deserialization of native elements.
==========

to

==========
Compute and cache element NativeBehavior during resolution.

NativeBehavior for method calls and field load/store are now computed
during resolution and apply as part of the world impact. This prepares
for (full) serialization/deserialization of native elements.

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/286b21133b8f64467fbce6b92e67ff4b3f28d782
==========

[Johnni Winther, 2016-06-09 07:50:58]

Committed patchset #4 (id:60001) manually as
286b21133b8f64467fbce6b92e67ff4b3f28d782 (presubmit successful).

[Johnni Winther, 2016-06-10 07:58:52]

https://codereview.chromium.org/2045223002/diff/20001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/common/backend_api.dart (right):

https://codereview.chromium.org/2045223002/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/backend_api.dart:410: void registerNativeData(var
nativeData);
On 2016/06/08 16:34:42, Harry Terkelsen wrote:
> I think this should be 'NativeBehavior nativeData'

It should have been 'dynamic' (it is in ResolutionWorldImpact). It is
deliberately _not_ NativeBehavior because the actual type is Target specific.

https://codereview.chromium.org/2045223002/diff/20001/pkg/compiler/lib/src/na...
File pkg/compiler/lib/src/native/enqueue.dart (right):

https://codereview.chromium.org/2045223002/diff/20001/pkg/compiler/lib/src/na...
pkg/compiler/lib/src/native/enqueue.dart:38: // [handleMethodAnnotations] to
[JavaScriptBackend] or [NativeData].
On 2016/06/08 16:34:42, Harry Terkelsen wrote:
> do these do anything if the element is not native? I see that it is called
> before checking if it is actually native. If it does nothing for non-native
> elements then it can just be executed when you register the native element.

Adding a TODO to make them return a bool; they actually compute whether the
element is native.