pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart - Issue 2045223002: Compute and cache element NativeBehavior during resolution.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart

Issue 2045223002: Compute and cache element NativeBehavior during resolution. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Temporarily skip compilation subtest Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart

diff --git a/pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart b/pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart

index a65d3e37454b10d0f29a8960e08d8301d9706fca..c2956ff5d08d7fe2550c794949008cd940f13ab9 100644

--- a/pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart

+++ b/pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart

@@ -290,10 +290,7 @@ abstract class InferrerEngine<T, V extends TypeSystem>

}

bool isNativeElement(Element element) {

- if (compiler.backend.isNative(element)) return true;

- return element.isClassMember &&

- compiler.backend.isNative(element.enclosingClass) &&

- element.isField;

+ return compiler.backend.isNative(element);

}

void analyze(ResolvedAst resolvedAst, ArgumentsTypes arguments);