Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2045153003:
Speculatively launch Service Workers on mouse/touch events. [4/5] (Closed)
|
Created:
4 years, 6 months ago by horo Modified:
4 years, 4 months ago CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, blink-reviews-html_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, dglazkov+blink, darin-cc_chromium.org, asvitkine+watch_chromium.org, blink-reviews, horo+watch_chromium.org, kinuko+watch, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSpeculatively launch Service Workers on mouse/touch events. [4/5]
1/5: Introduce NavigationHintSender.
https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ChromeRenderMessageFilter
https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ChromeRenderMessageFilter
https://codereview.chromium.org/2052613003/
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
This CL.
5/5: Add flags to enable SupeculativeLaunchServiceWorker
https://codereview.chromium.org/2053573002/
This CL introduces "ServiceWorker.NavigationHintPrecision" UMA to measure the
precision of the speculative launch of Service Workers for navigation hints.
It is recorded when the speculatively launched worker is stopped.
If there was no event fetched to the worker, this value is false.
This means that the speculative launch was meaningless.
BUG=616502
Committed: https://crrev.com/b9d6af8dfc9c1bcaabe9d67dd6c30c30b3873cbb
Cr-Commit-Position: refs/heads/master@{#409436}
Patch Set 1 #Patch Set 2 : add test #
Total comments: 12
Patch Set 3 : incorporated nhiroki's comment #Patch Set 4 : fix windows compile error #
Total comments: 10
Patch Set 5 : incorporated nhiroki's comment #
Messages
Total messages: 62 (48 generated)
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Description was changed from
==========
004
==========
to
==========
Speculatively launch Service Workers on mouse/touch events. [4/5]
1/5: Introduce NavigationHintSender.
https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ChromeRenderMessageFilter
https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ChromeRenderMessageFilter
https://codereview.chromium.org/2052613003/
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
This CL.
5/5: Add flags to enable SupeculativeLaunchServiceWorker
https://codereview.chromium.org/2053573002/
This CL introduces "ServiceWorker.NavigationHintPrecision" UMA to measure the
precision of the speculative launch of Service Workers for navigation hints.
It is recorded when the worker is stopped.
If there was no event fetched to the worker after the speculative launch, this
value is false.
This means that the speculative launch was meaningless.
BUG=616502
==========
Description was changed from
==========
Speculatively launch Service Workers on mouse/touch events. [4/5]
1/5: Introduce NavigationHintSender.
https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ChromeRenderMessageFilter
https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ChromeRenderMessageFilter
https://codereview.chromium.org/2052613003/
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
This CL.
5/5: Add flags to enable SupeculativeLaunchServiceWorker
https://codereview.chromium.org/2053573002/
This CL introduces "ServiceWorker.NavigationHintPrecision" UMA to measure the
precision of the speculative launch of Service Workers for navigation hints.
It is recorded when the worker is stopped.
If there was no event fetched to the worker after the speculative launch, this
value is false.
This means that the speculative launch was meaningless.
BUG=616502
==========
to
==========
Speculatively launch Service Workers on mouse/touch events. [4/5]
1/5: Introduce NavigationHintSender.
https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ChromeRenderMessageFilter
https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ChromeRenderMessageFilter
https://codereview.chromium.org/2052613003/
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
This CL.
5/5: Add flags to enable SupeculativeLaunchServiceWorker
https://codereview.chromium.org/2053573002/
This CL introduces "ServiceWorker.NavigationHintPrecision" UMA to measure the
precision of the speculative launch of Service Workers for navigation hints.
It is recorded when the speculatively launched worker is stopped.
If there was no event fetched to the worker, this value is false.
This means that the speculative launch was meaningless.
BUG=616502
==========
Patchset #4 (id:100001) has been deleted
Patchset #3 (id:80001) has been deleted
Description was changed from
==========
Speculatively launch Service Workers on mouse/touch events. [4/5]
1/5: Introduce NavigationHintSender.
https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ChromeRenderMessageFilter
https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ChromeRenderMessageFilter
https://codereview.chromium.org/2052613003/
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
This CL.
5/5: Add flags to enable SupeculativeLaunchServiceWorker
https://codereview.chromium.org/2053573002/
This CL introduces "ServiceWorker.NavigationHintPrecision" UMA to measure the
precision of the speculative launch of Service Workers for navigation hints.
It is recorded when the speculatively launched worker is stopped.
If there was no event fetched to the worker, this value is false.
This means that the speculative launch was meaningless.
BUG=616502
==========
to
==========
Speculatively launch Service Workers on mouse/touch events. [4/5]
1/5: Introduce NavigationHintSender.
https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ResourceHintsHandlerImpl
https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ResourceHintsHandlerImpl
https://codereview.chromium.org/2052613003/
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
This CL.
5/5: Add flags to enable SupeculativeLaunchServiceWorker
https://codereview.chromium.org/2053573002/
This CL introduces "ServiceWorker.NavigationHintPrecision" UMA to measure the
precision of the speculative launch of Service Workers for navigation hints.
It is recorded when the speculatively launched worker is stopped.
If there was no event fetched to the worker, this value is false.
This means that the speculative launch was meaningless.
BUG=616502
==========
The CQ bit was checked by horo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from
==========
Speculatively launch Service Workers on mouse/touch events. [4/5]
1/5: Introduce NavigationHintSender.
https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ResourceHintsHandlerImpl
https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ResourceHintsHandlerImpl
https://codereview.chromium.org/2052613003/
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
This CL.
5/5: Add flags to enable SupeculativeLaunchServiceWorker
https://codereview.chromium.org/2053573002/
This CL introduces "ServiceWorker.NavigationHintPrecision" UMA to measure the
precision of the speculative launch of Service Workers for navigation hints.
It is recorded when the speculatively launched worker is stopped.
If there was no event fetched to the worker, this value is false.
This means that the speculative launch was meaningless.
BUG=616502
==========
to
==========
Speculatively launch Service Workers on mouse/touch events. [4/5]
1/5: Introduce NavigationHintSender.
https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ChromeRenderMessageFilter
https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ChromeRenderMessageFilter
https://codereview.chromium.org/2052613003/
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
This CL.
5/5: Add flags to enable SupeculativeLaunchServiceWorker
https://codereview.chromium.org/2053573002/
This CL introduces "ServiceWorker.NavigationHintPrecision" UMA to measure the
precision of the speculative launch of Service Workers for navigation hints.
It is recorded when the speculatively launched worker is stopped.
If there was no event fetched to the worker, this value is false.
This means that the speculative launch was meaningless.
BUG=616502
==========
Patchset #7 (id:200001) has been deleted
Patchset #6 (id:180001) has been deleted
Patchset #5 (id:160001) has been deleted
Patchset #4 (id:140001) has been deleted
Patchset #3 (id:120001) has been deleted
Patchset #2 (id:60001) has been deleted
Patchset #1 (id:40001) has been deleted
The CQ bit was checked by horo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by horo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:240001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
horo@chromium.org changed reviewers: + nhiroki@chromium.org
horo@chromium.org changed reviewers: + nhiroki@chromium.org
nhiroki@ Could you please review this?
nhiroki@ Could you please review this?
https://codereview.chromium.org/2045153003/diff/260001/content/browser/servic... File content/browser/service_worker/service_worker_metrics.cc (right): https://codereview.chromium.org/2045153003/diff/260001/content/browser/servic... content/browser/service_worker/service_worker_metrics.cc:420: bool event_fired) { DCHECK(IsNavigationHintEvent(start_worker_purpose)) https://codereview.chromium.org/2045153003/diff/260001/content/browser/servic... content/browser/service_worker/service_worker_metrics.cc:437: // Do nothing. NOTREACHED() https://codereview.chromium.org/2045153003/diff/260001/content/browser/servic... File content/browser/service_worker/service_worker_metrics.h (right): https://codereview.chromium.org/2045153003/diff/260001/content/browser/servic... content/browser/service_worker/service_worker_metrics.h:206: // event fetched to the worker, |event_fired| is false. This means that the fetched to -> fired on? https://codereview.chromium.org/2045153003/diff/260001/content/browser/servic... content/browser/service_worker/service_worker_metrics.h:207: // speculative launch was meaningless. 'meaningless' sounds somewhat negative. How about 'wasn't helpful'? https://codereview.chromium.org/2045153003/diff/260001/content/browser/servic... File content/browser/service_worker/service_worker_version.cc (right): https://codereview.chromium.org/2045153003/diff/260001/content/browser/servic... content/browser/service_worker/service_worker_version.cc:215: start_worker_purpose_, !event_stats_.empty()); Regarding |event_fired|, we might want to filter out events other than FETCH_MAIN_FRAME because we mean to speculatively launch a worker for main resource navigation, and counting other events could be noisy. https://codereview.chromium.org/2045153003/diff/260001/content/browser/servic... File content/browser/service_worker/service_worker_version.h (right): https://codereview.chromium.org/2045153003/diff/260001/content/browser/servic... content/browser/service_worker/service_worker_version.h:736: std::unique_ptr<ServiceWorkerMetrics::EventType> start_worker_first_purpose_; base::Optional<ServiceWorkerMetrics::EventType> could work? https://chromium.googlesource.com/chromium/src/+/master/docs/optional.md
The CQ bit was checked by horo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by horo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2045153003/diff/260001/content/browser/servic... File content/browser/service_worker/service_worker_metrics.cc (right): https://codereview.chromium.org/2045153003/diff/260001/content/browser/servic... content/browser/service_worker/service_worker_metrics.cc:420: bool event_fired) { On 2016/07/28 05:38:36, nhiroki wrote: > DCHECK(IsNavigationHintEvent(start_worker_purpose)) Done. https://codereview.chromium.org/2045153003/diff/260001/content/browser/servic... content/browser/service_worker/service_worker_metrics.cc:437: // Do nothing. On 2016/07/28 05:38:36, nhiroki wrote: > NOTREACHED() Done. https://codereview.chromium.org/2045153003/diff/260001/content/browser/servic... File content/browser/service_worker/service_worker_metrics.h (right): https://codereview.chromium.org/2045153003/diff/260001/content/browser/servic... content/browser/service_worker/service_worker_metrics.h:206: // event fetched to the worker, |event_fired| is false. This means that the On 2016/07/28 05:38:37, nhiroki wrote: > fetched to -> fired on? Done. https://codereview.chromium.org/2045153003/diff/260001/content/browser/servic... content/browser/service_worker/service_worker_metrics.h:207: // speculative launch was meaningless. On 2016/07/28 05:38:37, nhiroki wrote: > 'meaningless' sounds somewhat negative. How about 'wasn't helpful'? Done. https://codereview.chromium.org/2045153003/diff/260001/content/browser/servic... File content/browser/service_worker/service_worker_version.cc (right): https://codereview.chromium.org/2045153003/diff/260001/content/browser/servic... content/browser/service_worker/service_worker_version.cc:215: start_worker_purpose_, !event_stats_.empty()); On 2016/07/28 05:38:37, nhiroki wrote: > Regarding |event_fired|, we might want to filter out events other than > FETCH_MAIN_FRAME because we mean to speculatively launch a worker for main > resource navigation, and counting other events could be noisy. Done. https://codereview.chromium.org/2045153003/diff/260001/content/browser/servic... File content/browser/service_worker/service_worker_version.h (right): https://codereview.chromium.org/2045153003/diff/260001/content/browser/servic... content/browser/service_worker/service_worker_version.h:736: std::unique_ptr<ServiceWorkerMetrics::EventType> start_worker_first_purpose_; On 2016/07/28 05:38:37, nhiroki wrote: > base::Optional<ServiceWorkerMetrics::EventType> could work? > https://chromium.googlesource.com/chromium/src/+/master/docs/optional.md Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by horo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
lgtm with minor comments https://codereview.chromium.org/2045153003/diff/300001/content/browser/servic... File content/browser/service_worker/service_worker_version.cc (right): https://codereview.chromium.org/2045153003/diff/300001/content/browser/servic... content/browser/service_worker/service_worker_version.cc:1761: base::Optional<ServiceWorkerMetrics::EventType>(); start_worker_first_purpose = base::nullopt_t; https://codereview.chromium.org/2045153003/diff/300001/content/browser/servic... File content/browser/service_worker/service_worker_version_unittest.cc (right): https://codereview.chromium.org/2045153003/diff/300001/content/browser/servic... content/browser/service_worker/service_worker_version_unittest.cc:1333: ServiceWorkerStatusCode status2 = SERVICE_WORKER_ERROR_FAILED; To emphasize this is a dummy error value, I use SERVICE_WORKER_ERROR_MAX_VALUE these days. https://codereview.chromium.org/2045153003/diff/300001/content/browser/servic... content/browser/service_worker/service_worker_version_unittest.cc:1601: for (const auto& unchanged_historam_name : unchanged_historam_names) { |const char*| could be a bit more readable. JFYI: Using an 'auto' keyword for a raw pointer is now under discussion: https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-dev/auto/c... https://codereview.chromium.org/2045153003/diff/300001/content/browser/servic... content/browser/service_worker/service_worker_version_unittest.cc:1603: } nit: Curly braces are not necessary for one line body here and somewhere else. https://codereview.chromium.org/2045153003/diff/300001/tools/metrics/histogra... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2045153003/diff/300001/tools/metrics/histogra... tools/metrics/histograms/histograms.xml:51809: + <owner>horo@google.com</owner> @chromium.org
The CQ bit was checked by horo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Thank you. https://codereview.chromium.org/2045153003/diff/300001/content/browser/servic... File content/browser/service_worker/service_worker_version.cc (right): https://codereview.chromium.org/2045153003/diff/300001/content/browser/servic... content/browser/service_worker/service_worker_version.cc:1761: base::Optional<ServiceWorkerMetrics::EventType>(); On 2016/07/29 06:08:03, nhiroki wrote: > start_worker_first_purpose = base::nullopt_t; Done. https://codereview.chromium.org/2045153003/diff/300001/content/browser/servic... File content/browser/service_worker/service_worker_version_unittest.cc (right): https://codereview.chromium.org/2045153003/diff/300001/content/browser/servic... content/browser/service_worker/service_worker_version_unittest.cc:1333: ServiceWorkerStatusCode status2 = SERVICE_WORKER_ERROR_FAILED; On 2016/07/29 06:08:03, nhiroki wrote: > To emphasize this is a dummy error value, I use SERVICE_WORKER_ERROR_MAX_VALUE > these days. Done. https://codereview.chromium.org/2045153003/diff/300001/content/browser/servic... content/browser/service_worker/service_worker_version_unittest.cc:1601: for (const auto& unchanged_historam_name : unchanged_historam_names) { On 2016/07/29 06:08:03, nhiroki wrote: > |const char*| could be a bit more readable. > > JFYI: Using an 'auto' keyword for a raw pointer is now under discussion: > https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-dev/auto/c... Done. https://codereview.chromium.org/2045153003/diff/300001/content/browser/servic... content/browser/service_worker/service_worker_version_unittest.cc:1603: } On 2016/07/29 06:08:03, nhiroki wrote: > nit: Curly braces are not necessary for one line body here and somewhere else. Done. https://codereview.chromium.org/2045153003/diff/300001/tools/metrics/histogra... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2045153003/diff/300001/tools/metrics/histogra... tools/metrics/histograms/histograms.xml:51809: + <owner>horo@google.com</owner> On 2016/07/29 06:08:03, nhiroki wrote: > @chromium.org Done.
horo@chromium.org changed reviewers: + mpearson@chromium.org
mpearson@ Could you please review tools/metrics/histograms/histograms.xml?
horo@chromium.org changed reviewers: + rkaplow@chromium.org
rkaplow@ Could you please review histograms.xml?
lgtm
On Fri, Jul 29, 2016 at 2:02 AM, <horo@chromium.org> wrote: > mpearson@ > Could you please review tools/metrics/histograms/histograms.xml? > Sorry `bout that. I don't know how I missed this. I'm glad you followed-up. --mark > > https://codereview.chromium.org/2045153003/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
On Fri, Jul 29, 2016 at 2:02 AM, <horo@chromium.org> wrote: > mpearson@ > Could you please review tools/metrics/histograms/histograms.xml? > Sorry `bout that. I don't know how I missed this. I'm glad you followed-up. --mark > > https://codereview.chromium.org/2045153003/ > -- You received this message because you are subscribed to the Google Groups "Blink Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-reviews+unsubscribe@chromium.org.
The CQ bit was checked by horo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nhiroki@chromium.org Link to the patchset: https://codereview.chromium.org/2045153003/#ps320001 (title: "incorporated nhiroki's comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from
==========
Speculatively launch Service Workers on mouse/touch events. [4/5]
1/5: Introduce NavigationHintSender.
https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ChromeRenderMessageFilter
https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ChromeRenderMessageFilter
https://codereview.chromium.org/2052613003/
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
This CL.
5/5: Add flags to enable SupeculativeLaunchServiceWorker
https://codereview.chromium.org/2053573002/
This CL introduces "ServiceWorker.NavigationHintPrecision" UMA to measure the
precision of the speculative launch of Service Workers for navigation hints.
It is recorded when the speculatively launched worker is stopped.
If there was no event fetched to the worker, this value is false.
This means that the speculative launch was meaningless.
BUG=616502
==========
to
==========
Speculatively launch Service Workers on mouse/touch events. [4/5]
1/5: Introduce NavigationHintSender.
https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ChromeRenderMessageFilter
https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ChromeRenderMessageFilter
https://codereview.chromium.org/2052613003/
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
This CL.
5/5: Add flags to enable SupeculativeLaunchServiceWorker
https://codereview.chromium.org/2053573002/
This CL introduces "ServiceWorker.NavigationHintPrecision" UMA to measure the
precision of the speculative launch of Service Workers for navigation hints.
It is recorded when the speculatively launched worker is stopped.
If there was no event fetched to the worker, this value is false.
This means that the speculative launch was meaningless.
BUG=616502
==========
Message was sent while issue was closed.
Committed patchset #5 (id:320001)
Message was sent while issue was closed.
Description was changed from
==========
Speculatively launch Service Workers on mouse/touch events. [4/5]
1/5: Introduce NavigationHintSender.
https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ChromeRenderMessageFilter
https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ChromeRenderMessageFilter
https://codereview.chromium.org/2052613003/
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
This CL.
5/5: Add flags to enable SupeculativeLaunchServiceWorker
https://codereview.chromium.org/2053573002/
This CL introduces "ServiceWorker.NavigationHintPrecision" UMA to measure the
precision of the speculative launch of Service Workers for navigation hints.
It is recorded when the speculatively launched worker is stopped.
If there was no event fetched to the worker, this value is false.
This means that the speculative launch was meaningless.
BUG=616502
==========
to
==========
Speculatively launch Service Workers on mouse/touch events. [4/5]
1/5: Introduce NavigationHintSender.
https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ChromeRenderMessageFilter
https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ChromeRenderMessageFilter
https://codereview.chromium.org/2052613003/
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
This CL.
5/5: Add flags to enable SupeculativeLaunchServiceWorker
https://codereview.chromium.org/2053573002/
This CL introduces "ServiceWorker.NavigationHintPrecision" UMA to measure the
precision of the speculative launch of Service Workers for navigation hints.
It is recorded when the speculatively launched worker is stopped.
If there was no event fetched to the worker, this value is false.
This means that the speculative launch was meaningless.
BUG=616502
Committed: https://crrev.com/b9d6af8dfc9c1bcaabe9d67dd6c30c30b3873cbb
Cr-Commit-Position: refs/heads/master@{#409436}
==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/b9d6af8dfc9c1bcaabe9d67dd6c30c30b3873cbb Cr-Commit-Position: refs/heads/master@{#409436} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
