scripts/slave/recipe_modules/bisect_tester/api.py - Issue 2045043002: Allow multiple devices on bisects hosts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/bisect_tester/api.py

Issue 2045043002: Allow multiple devices on bisects hosts (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Update unexpected files Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/bisect_tester/api.py

diff --git a/scripts/slave/recipe_modules/bisect_tester/api.py b/scripts/slave/recipe_modules/bisect_tester/api.py

index 53181308999431813973d751cb20ebcf3688d76a..7c6561adfee9515ccf9a2ba04c683d062f12d941 100644

--- a/scripts/slave/recipe_modules/bisect_tester/api.py

+++ b/scripts/slave/recipe_modules/bisect_tester/api.py

@@ -17,6 +17,8 @@ class BisectTesterApi(recipe_api.RecipeApi):

def __init__(self, **kwargs):

super(BisectTesterApi, self).__init__(**kwargs)

+ self.device_to_test = None

dtu 2016/07/06 21:14:09 Call me an OOP purist, but I dislike having public

Ziqi Xiong 2016/07/07 01:44:24 See new issue: https://codereview.chromium.org/211

+ self.devices_tested = []

def local_test_enabled(self):

buildername = os.environ.get('BUILDBOT_BUILDERNAME')