Allow multiple devices on bisects hosts

scripts/slave/recipe_modules/bisect_tester/api.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import json
 import os
 
 from recipe_engine import recipe_api
 from . import perf_test
 
 BUCKET = 'chrome-perf'
 RESULTS_GS_DIR = 'bisect-results'
 
 
 class BisectTesterApi(recipe_api.RecipeApi):
   """A module for the bisect tester bot using the chromium recipe."""
 
   def __init__(self, **kwargs):
     super(BisectTesterApi, self).__init__(**kwargs)
+    self.device_to_test = None

[dtu, 2016/07/06 21:14:09]

Call me an OOP purist, but I dislike having public fields here. These should be
accessed with member functions instead.

[Ziqi Xiong, 2016/07/07 01:44:24]

See new issue: https://codereview.chromium.org/2119483003/#ps20001

+    self.devices_tested = []
 
   def local_test_enabled(self):
     buildername = os.environ.get('BUILDBOT_BUILDERNAME')
     cr_config = self.m.chromium.c
     if buildername and buildername.endswith('_bisect') and cr_config:
       return True # pragma: no cover
     return False
 
   def load_config_from_dict(self, bisect_config):
     """Copies the required configuration keys to a new dict."""
@@ skipping 53 matching lines @@
           self.m.properties['mastername'],
           self.m.properties['buildername'],
           self.m.properties['buildnumber'])
     local_save_results = self.m.python('saving url to temp file',
                                        self.resource('put_temp.py'),
                                        stdout=self.m.raw_io.output(),
                                        stdin=self.m.raw_io.input(url))
     local_file = local_save_results.stdout.splitlines()[0].strip()
     self.m.gsutil.upload(
         local_file, BUCKET, gs_filename, name=str(gs_filename))