Issue 2045033002: Avoid const-cast in CPDF_Font

Issue 2045033002: Avoid const-cast in CPDF_Font (Closed)

Created:
4 years, 6 months ago by Tom Sepez

Modified:
4 years, 6 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

Avoid const-cast in CPDF_Font Introduce a logically const initialization (via mutable members) so that this can happen lazily under const methods. Committed: https://pdfium.googlesource.com/pdfium/+/a431e238ee42025cce44c3a76dd07c470d7f51ec

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	core/fpdfapi/fpdf_font/cpdf_font.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download
	M	core/fpdfapi/fpdf_font/include/cpdf_font.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 7 (3 generated)

Tom Sepez

Lei, for review, since you're most particular about mutablitly.

4 years, 6 months ago (2016-06-07 21:07:11 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045033002/20001

4 years, 6 months ago (2016-06-08 04:43:36 UTC) #5

commit-bot: I haz the power

4 years, 6 months ago (2016-06-08 04:56:54 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/a431e238ee42025cce44c3a76dd07c470d7f...