Avoid const-cast in CPDF_Font

core/fpdfapi/fpdf_font/cpdf_font.cpp

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfapi/fpdf_font/include/cpdf_font.h"
 
 #include <memory>
 
@@ skipping 147 matching lines @@
   int len = AppendChar(buf, charcode);
   if (len == 1) {
     str += buf[0];
   } else {
     str += CFX_ByteString(buf, len);
   }
 }
 
 CFX_WideString CPDF_Font::UnicodeFromCharCode(uint32_t charcode) const {
   if (!m_bToUnicodeLoaded)
-    ((CPDF_Font*)this)->LoadUnicodeMap();
+    LoadUnicodeMap();
 
   if (m_pToUnicodeMap)
     return m_pToUnicodeMap->Lookup(charcode);
   return CFX_WideString();
 }
 
 uint32_t CPDF_Font::CharCodeFromUnicode(FX_WCHAR unicode) const {
   if (!m_bToUnicodeLoaded)
-    ((CPDF_Font*)this)->LoadUnicodeMap();
+    LoadUnicodeMap();
 
   if (m_pToUnicodeMap)
     return m_pToUnicodeMap->ReverseLookup(unicode);
   return 0;
 }
 
 void CPDF_Font::LoadFontDescriptor(CPDF_Dictionary* pFontDesc) {
   m_Flags = pFontDesc->GetIntegerBy("Flags", PDFFONT_NONSYMBOLIC);
   int ItalicAngle = 0;
   FX_BOOL bExistItalicAngle = FALSE;
@@ skipping 99 matching lines @@
     }
   }
   if (m_Ascent == 0 && m_Descent == 0) {
     FX_RECT rect = GetCharBBox('A');
     m_Ascent = rect.bottom == rect.top ? m_FontBBox.top : rect.top;
     rect = GetCharBBox('g');
     m_Descent = rect.bottom == rect.top ? m_FontBBox.bottom : rect.bottom;
   }
 }
 
-void CPDF_Font::LoadUnicodeMap() {
+void CPDF_Font::LoadUnicodeMap() const {
   m_bToUnicodeLoaded = TRUE;
   CPDF_Stream* pStream = m_pFontDict->GetStreamBy("ToUnicode");
   if (!pStream) {
     return;
   }
   m_pToUnicodeMap = new CPDF_ToUnicodeMap;
   m_pToUnicodeMap->Load(pStream);
 }
 
 int CPDF_Font::GetStringWidth(const FX_CHAR* pString, int size) {
@@ skipping 154 matching lines @@
   if (charcode < 0 || charcode >= 256)
     return nullptr;
 
   const FX_CHAR* name = nullptr;
   if (pCharNames)
     name = pCharNames[charcode].c_str();
   if ((!name || name[0] == 0) && iBaseEncoding)
     name = PDF_CharNameFromPredefinedCharSet(iBaseEncoding, charcode);
   return name && name[0] ? name : nullptr;
 }