Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py

Issue 2045013002: Fix test_importer.py to skip files named reftest.list and add test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added comment Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
index 2551d9418429bd9568b6b9d41a8b25e65e0afe2f..273b78423be397b246e9ff8a6b6897559d1459aa 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
@@ -41,7 +41,9 @@ FAKE_REPO_DIR = '/blink'
FAKE_FILES = {'/mock-checkout/third_party/Webkit/LayoutTests/w3c/OWNERS': '',
'/blink/w3c/dir/README.txt': '',
'/blink/w3c/dir/OWNERS': '',
+ '/blink/w3c/dir/reftest.list': '',
'/blink/w3c/dir1/OWNERS': '',
+ '/blink/w3c/dir1/reftest.list': '',
'/mock-checkout/third_party/WebKit/LayoutTests/w3c/README.txt': '',
'/mock-checkout/third_party/WebKit/LayoutTests/W3CImportExpectations': ''}
@@ -95,3 +97,15 @@ class TestImporterTest(unittest.TestCase):
'jstests': 0,
'reftests': 0,
'total_tests': 0}])
+
+ def test_does_not_import_reftest(self):
+ host = MockHost()
+ host.filesystem = MockFileSystem(files=FAKE_FILES)
+ importer = TestImporter(host, FAKE_SOURCE_DIR, FAKE_REPO_DIR, self.options())
+ importer.find_importable_tests(FAKE_REPO_DIR)
+ self.assertEqual(importer.import_list,
+ [{'copy_list': [{'dest': 'README.txt', 'src': '/blink/w3c/dir/README.txt'}],
+ 'dirname': '/blink/w3c/dir',
+ 'jstests': 0,
+ 'reftests': 0,
+ 'total_tests': 0}])

Powered by Google App Engine
This is Rietveld 408576698