Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 2044943002: Revert of Use /LTCG:Incremental to speed up the non-clobber official builds. (patchset #2 id:20001 … (Closed)

Created:
4 years, 6 months ago by Sébastien Marchand
Modified:
4 years, 6 months ago
Reviewers:
brucedawson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2761
Target Ref:
refs/pending/branch-heads/2761
Project:
chromium
Visibility:
Public.

Description

Revert of Use /LTCG:Incremental to speed up the non-clobber official builds. (patchset #2 id:20001 of https://codereview.chromium.org/2045683002/ ) Reason for revert: I'm seeing some compiler issue on the Win perf builders (https://uberchromegw.corp.google.com/i/chromium.perf/builders/Win%20x64%20Builder/builds/9316/steps/compile/logs/stdio) : fatal error C1001: An internal error has occurred in the compiler BUG=616946 Original issue's description: > Use /LTCG:Incremental to speed up the non-clobber official builds. > > /LTCG:Incremental is different from /INCREMENTAL, it speeds-up the link time of the WPO build without affecting the code quality and the performance, see https://blogs.msdn.microsoft.com/vcblog/2014/11/12/speeding-up-the-incremental-developer-build-scenario/ for more details on this. > > Committed: https://crrev.com/98fccebb0a5f6f1307ed1e598418fa472a8e1800 > Cr-Commit-Position: refs/heads/master@{#398153} TBR=brucedawson@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2035313007 Cr-Commit-Position: refs/heads/master@{#398279} (cherry picked from commit 2e304ec9ca19c8113db6b49405d6b2dd6d8cf2cd) Committed: https://chromium.googlesource.com/chromium/src/+/b4d6cba233fd3e2e1a7b70f5f0f5387ebf0039d1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M build/common.gypi View 1 chunk +2 lines, -5 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Sébastien Marchand
4 years, 6 months ago (2016-06-07 18:02:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b4d6cba233fd3e2e1a7b70f5f0f5387ebf0039d1.

Powered by Google App Engine
This is Rietveld 408576698