Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1210)

Issue 2035313007: Revert of Use /LTCG:Incremental to speed up the non-clobber official builds. (Closed)

Created:
4 years, 6 months ago by Sébastien Marchand
Modified:
4 years, 6 months ago
Reviewers:
brucedawson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use /LTCG:Incremental to speed up the non-clobber official builds. (patchset #2 id:20001 of https://codereview.chromium.org/2045683002/ ) Reason for revert: I'm seeing some compiler issue on the Win perf builders (https://uberchromegw.corp.google.com/i/chromium.perf/builders/Win%20x64%20Builder/builds/9316/steps/compile/logs/stdio) : fatal error C1001: An internal error has occurred in the compiler BUG=616946 Original issue's description: > Use /LTCG:Incremental to speed up the non-clobber official builds. > > /LTCG:Incremental is different from /INCREMENTAL, it speeds-up the link time of the WPO build without affecting the code quality and the performance, see https://blogs.msdn.microsoft.com/vcblog/2014/11/12/speeding-up-the-incremental-developer-build-scenario/ for more details on this. > > Committed: https://crrev.com/98fccebb0a5f6f1307ed1e598418fa472a8e1800 > Cr-Commit-Position: refs/heads/master@{#398153} TBR=brucedawson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/2e304ec9ca19c8113db6b49405d6b2dd6d8cf2cd Cr-Commit-Position: refs/heads/master@{#398279}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M build/common.gypi View 1 chunk +2 lines, -5 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Sébastien Marchand
Created Revert of Use /LTCG:Incremental to speed up the non-clobber official builds.
4 years, 6 months ago (2016-06-07 12:41:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2035313007/1
4 years, 6 months ago (2016-06-07 12:41:23 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 12:42:00 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 12:44:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e304ec9ca19c8113db6b49405d6b2dd6d8cf2cd
Cr-Commit-Position: refs/heads/master@{#398279}

Powered by Google App Engine
This is Rietveld 408576698