Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2044673003: Honour PartitionAllocReturnNull flag when MEMORY_TOOL_REPLACES_ALLOCATOR (Closed)

Created:
4 years, 6 months ago by caitp (gmail)
Modified:
4 years, 6 months ago
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Honour PartitionAllocReturnNull flag when MEMORY_TOOL_REPLACES_ALLOCATOR Previously, for builds defining MEMORY_TOOL_REPLACES_ALLOCATOR, the PartitionAllocReturnNull flag was not respected. This can causes problems on cluster-fuzz, due to generating valid scripts which ought to just throw a RangeError (as they do in ordinary builds) rather than crashing. BUG=617628 R=jochen@chromium.org, littledan@chromium.org Committed: https://crrev.com/7757f92ee97b2668c3f412fa0ebdb62321d8bd0d Cr-Commit-Position: refs/heads/master@{#398422}

Patch Set 1 #

Patch Set 2 : Change CHECK back to RELEASE_ASSERT due to the reported "12.5%-56.9% perf regression" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
caitp (gmail)
Please take a quick look
4 years, 6 months ago (2016-06-07 12:05:50 UTC) #1
Dan Ehrenberg
lgtm Seems good to me, but someone with more experience in this code should also ...
4 years, 6 months ago (2016-06-07 13:51:52 UTC) #3
caitp (gmail)
On 2016/06/07 13:51:52, Dan Ehrenberg wrote: > lgtm > > Seems good to me, but ...
4 years, 6 months ago (2016-06-07 15:59:35 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-07 18:48:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044673003/20001
4 years, 6 months ago (2016-06-07 19:07:36 UTC) #9
haraken
LGTM
4 years, 6 months ago (2016-06-07 23:37:06 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-07 23:59:04 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 00:00:46 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7757f92ee97b2668c3f412fa0ebdb62321d8bd0d
Cr-Commit-Position: refs/heads/master@{#398422}

Powered by Google App Engine
This is Rietveld 408576698