third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h - Issue 2044673003: Honour PartitionAllocReturnNull flag when MEMORY_TOOL_REPLACES_ALLOCATOR

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h

Issue 2044673003: Honour PartitionAllocReturnNull flag when MEMORY_TOOL_REPLACES_ALLOCATOR (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change CHECK back to RELEASE_ASSERT due to the reported "12.5%-56.9% perf regression" Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h

diff --git a/third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h b/third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h

index f84e9f3bf26f7b5ad44ca2a03924b5f08db6c14d..19390943206a62ca41f81d46303e39ccdea8962e 100644

--- a/third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h

+++ b/third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h

@@ -734,7 +734,7 @@ ALWAYS_INLINE void* partitionAllocGenericFlags(PartitionRootGeneric* root, int f

{

#if defined(MEMORY_TOOL_REPLACES_ALLOCATOR)

void* result = malloc(size);

- RELEASE_ASSERT(result);

+ RELEASE_ASSERT(result || flags & PartitionAllocReturnNull);

return result;

#else

ASSERT(root->initialized);

« no previous file with comments | « no previous file | no next file » | no next file with comments »