Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2044653002: [Autofill] Fix the trucating of expiration year inputs. (Closed)

Created:
4 years, 6 months ago by sebsg
Modified:
4 years, 6 months ago
Reviewers:
Mathieu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

The previous CL was built around a test case I had made myself (there was no real life example). I found one and realized the type should be "text" and not "input". Related CL: https://codereview.chromium.org/2025063002/ BUG=616174 TEST=AutofillFieldTest Review-Url: https://codereview.chromium.org/2041863003 Cr-Commit-Position: refs/heads/master@{#398073} (cherry picked from commit 0f28ddfb76aff4a18095e19421f6bc1eb3975f0d) NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/autofill/core/browser/autofill_field.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_field_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
sebsg
PTAL?
4 years, 6 months ago (2016-06-06 20:14:32 UTC) #3
Mathieu
lgtm
4 years, 6 months ago (2016-06-06 20:29:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044653002/1
4 years, 6 months ago (2016-06-06 20:30:21 UTC) #6
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 6 months ago (2016-06-06 20:30:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044653002/1
4 years, 6 months ago (2016-06-06 20:34:51 UTC) #11
commit-bot: I haz the power
Failed to commit the patch.
4 years, 6 months ago (2016-06-06 20:37:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044653002/1
4 years, 6 months ago (2016-06-06 20:50:26 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 20:51:18 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698