Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 2041863003: [Autofill] Fix the trucating of expiration year inputs. (Closed)

Created:
4 years, 6 months ago by sebsg
Modified:
4 years, 6 months ago
Reviewers:
Mathieu
CC:
browser-components-watch_chromium.org, chromium-reviews, estade+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, rouslan+autofill_chromium.org, vabr+watchlistautofill_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The previous CL was built around a test case I had made myself (there was no real life example). I found one and realized the type should be "text" and not "input". Related CL: https://codereview.chromium.org/2025063002/ BUG=616174 TEST=AutofillFieldTest Committed: https://crrev.com/0f28ddfb76aff4a18095e19421f6bc1eb3975f0d Cr-Commit-Position: refs/heads/master@{#398073}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/autofill/core/browser/autofill_field.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_field_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
sebsg
PTAL?
4 years, 6 months ago (2016-06-06 16:45:06 UTC) #3
Mathieu
lgtm
4 years, 6 months ago (2016-06-06 17:06:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041863003/1
4 years, 6 months ago (2016-06-06 17:07:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 18:33:14 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 18:35:11 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f28ddfb76aff4a18095e19421f6bc1eb3975f0d
Cr-Commit-Position: refs/heads/master@{#398073}

Powered by Google App Engine
This is Rietveld 408576698